Skip to content

chore: quick code quality fixes from review (bubble sort, linter config, mutable maps) #75

Description

@digiserg

Summary

Small fixes identified during code review that can be done in a single PR.

I7: Replace bubble sort with slices.Sort

internal/controller/backups/axonopsbackup_controller.go:495-503 implements O(n²) sortStrings. Replace with slices.Sort(keys).

I3: Fix routeTypeMap encoding

internal/controller/alerts/axonopsalertroute_controller.go:42-51 stores pre-URL-encoded %20 values. Store display names, URL-encode at call site.

N5: Make lookup maps immutable

routeTypeMap and typedIntegrationTypes declared as var but intended read-only.

N4: Clean up scaffold TODOs

Remove TODO(user): comments from kubebuilder scaffolds. Convert internal FIXME (ASB-4338) to public GitHub issue reference.

N1: Fix Go acronym casing

CorrelationIdCorrelationID, WidgetUrlWidgetURL in internal/axonops/types.go.

Acceptance Criteria

  1. sortStrings function removed, replaced with slices.Sort
  2. routeTypeMap stores unencoded display names
  3. Zero TODO(user): scaffold comments (grep returns 0)
  4. CorrelationId and WidgetUrl renamed
  5. make lint passes

Priority

P3

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions