Summary
Small fixes identified during code review that can be done in a single PR.
I7: Replace bubble sort with slices.Sort
internal/controller/backups/axonopsbackup_controller.go:495-503 implements O(n²) sortStrings. Replace with slices.Sort(keys).
I3: Fix routeTypeMap encoding
internal/controller/alerts/axonopsalertroute_controller.go:42-51 stores pre-URL-encoded %20 values. Store display names, URL-encode at call site.
N5: Make lookup maps immutable
routeTypeMap and typedIntegrationTypes declared as var but intended read-only.
N4: Clean up scaffold TODOs
Remove TODO(user): comments from kubebuilder scaffolds. Convert internal FIXME (ASB-4338) to public GitHub issue reference.
N1: Fix Go acronym casing
CorrelationId → CorrelationID, WidgetUrl → WidgetURL in internal/axonops/types.go.
Acceptance Criteria
sortStrings function removed, replaced with slices.Sort
routeTypeMap stores unencoded display names
- Zero
TODO(user): scaffold comments (grep returns 0)
CorrelationId and WidgetUrl renamed
make lint passes
Priority
P3
Summary
Small fixes identified during code review that can be done in a single PR.
I7: Replace bubble sort with slices.Sort
internal/controller/backups/axonopsbackup_controller.go:495-503implements O(n²)sortStrings. Replace withslices.Sort(keys).I3: Fix routeTypeMap encoding
internal/controller/alerts/axonopsalertroute_controller.go:42-51stores pre-URL-encoded%20values. Store display names, URL-encode at call site.N5: Make lookup maps immutable
routeTypeMapandtypedIntegrationTypesdeclared asvarbut intended read-only.N4: Clean up scaffold TODOs
Remove
TODO(user):comments from kubebuilder scaffolds. Convert internal FIXME (ASB-4338) to public GitHub issue reference.N1: Fix Go acronym casing
CorrelationId→CorrelationID,WidgetUrl→WidgetURLininternal/axonops/types.go.Acceptance Criteria
sortStringsfunction removed, replaced withslices.SortrouteTypeMapstores unencoded display namesTODO(user):scaffold comments (grep returns 0)CorrelationIdandWidgetUrlrenamedmake lintpassesPriority
P3