From 40a75a943974fa5ceb652abdf0353be97e1f406f Mon Sep 17 00:00:00 2001 From: Maksim Korotkov Date: Wed, 4 Mar 2026 12:35:19 +0300 Subject: [PATCH] process_common: fixed handle leak Signed-off-by: Maksim Korotkov --- source/process_common.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/source/process_common.c b/source/process_common.c index 24a25094b..7a0e92b59 100644 --- a/source/process_common.c +++ b/source/process_common.c @@ -48,7 +48,7 @@ int aws_run_command( AWS_FATAL_ASSERT(options); AWS_FATAL_ASSERT(result); - FILE *output_stream; + FILE *output_stream = NULL; char output_buffer[MAX_BUFFER_SIZE]; struct aws_byte_buf result_buffer; int ret = AWS_OP_ERR; @@ -71,11 +71,6 @@ int aws_run_command( } } } -# if defined(AWS_OS_WINDOWS) - result->ret_code = _pclose(output_stream); -# else - result->ret_code = pclose(output_stream); -# endif } struct aws_byte_cursor trim_cursor = aws_byte_cursor_from_buf(&result_buffer); @@ -89,6 +84,13 @@ int aws_run_command( ret = AWS_OP_SUCCESS; on_finish: + if (output_stream) { +# if defined(AWS_OS_WINDOWS) + _pclose(output_stream); +# else + pclose(output_stream); +# endif + } aws_byte_buf_clean_up_secure(&result_buffer); return ret; }