Build SDK for Amazon Linux 2023

[omaslieiev]

I use your SDK in AL2 but now I make upgrade to AL2023 and try build SDK for it. During build procedure got an error from here tests/benchmark/benchmark.cpp in line 14:
error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
All another code build correct.I need to fix it. What the best way for it? Can you fix it or should I open request with changes that I do or maybe another way.

[jmklix]

Warnings are treated as errors when building this sdk. This specific warning is just a suggestion to add a parentheses to remove ambiguity. You can avoid this error by building without -Werror enabled or by disabling tests altogether with -DENABLE_TESTING=OFF

I also made a PR that should fix this warning: #2999

[omaslieiev]

Should I add -Werror flag to build procedure in one of CMakeLists.txt file or just add -DENABLE_TESTING=OFF to cmake command?

[jmklix]

If you have no preference, it's probably easiest to add -DENABLE_TESTING=OFF to cmake command. It might look something like this:

cmake .. -DBUILD_ONLY="s3;s3-crt" -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX="<install-path>" -DENABLE_TESTING=OFF

[omaslieiev]

If I want to build benchmark with -DBUILD_BENCHMARKS=ON will -DENABLE_TESTING=OFF help to avoid error parentheses?

[jmklix]

Yes, kind of. This only works because this warning ("error"), is in the tests. If you are ok with not running the tests then this should work for you.

A different way to fix this is to turn off Werror's. You can do that by adding -DCMAKE_CXX_FLAGS="-Wno-error"

[github-actions[bot]]

Hello! Reopening this discussion to make it searchable.