Skip to content

Commit 8f1da9f

Browse files
committed
fixing header issue before merge
client config update
1 parent 6025f1a commit 8f1da9f

3 files changed

Lines changed: 38 additions & 16 deletions

File tree

src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/DownloadHandle.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,13 @@ namespace Aws {
1313
namespace S3 {
1414
namespace Transfer {
1515

16-
namespace Internal {
17-
class DownloadHandleImpl;
18-
}
19-
2016
/**
2117
* Returned from S3TransferManager::Download to represent a single in-flight download. The
2218
* handle is move-only and owns the underlying transfer state.
2319
*/
2420
class AWS_S3_TRANSFER_API DownloadHandle final {
2521
public:
2622
DownloadHandle();
27-
DownloadHandle(Aws::UniquePtr<Internal::DownloadHandleImpl> impl);
2823
~DownloadHandle();
2924
DownloadHandle(DownloadHandle&&) noexcept;
3025
DownloadHandle& operator=(DownloadHandle&&) noexcept;
@@ -39,9 +34,6 @@ class AWS_S3_TRANSFER_API DownloadHandle final {
3934
* returned by CompletionFuture will resolve with a failure once the cancel takes effect.
4035
*/
4136
void Cancel();
42-
43-
private:
44-
Aws::UniquePtr<Internal::DownloadHandleImpl> m_impl;
4537
};
4638

4739

src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/UploadHandle.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,13 @@ namespace Aws {
1313
namespace S3 {
1414
namespace Transfer {
1515

16-
namespace Internal {
17-
class UploadHandleImpl;
18-
}
19-
2016
/**
2117
* Returned from S3TransferManager::Upload to represent a single in-flight upload. The
2218
* handle is move-only and owns the underlying transfer state.
2319
*/
2420
class AWS_S3_TRANSFER_API UploadHandle final {
2521
public:
2622
UploadHandle();
27-
UploadHandle(Aws::UniquePtr<Internal::UploadHandleImpl> impl);
2823
~UploadHandle();
2924
UploadHandle(UploadHandle&&) noexcept;
3025
UploadHandle& operator=(UploadHandle&&) noexcept;
@@ -40,9 +35,6 @@ class AWS_S3_TRANSFER_API UploadHandle final {
4035
* returned by CompletionFuture will resolve with a failure once the cancel takes effect.
4136
*/
4237
void Cancel();
43-
44-
private:
45-
Aws::UniquePtr<Internal::UploadHandleImpl> m_impl;
4638
};
4739

4840

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
/**
2+
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
3+
* SPDX-License-Identifier: Apache-2.0.
4+
*/
5+
6+
#include <aws/s3-transfer/S3TransferManagerConfiguration.h>
7+
8+
namespace Aws {
9+
namespace S3 {
10+
namespace Transfer {
11+
12+
void S3TransferManagerConfiguration::LoadS3TransferManagerSpecificConfig(const Aws::String& inputProfileName) {
13+
(void)inputProfileName;
14+
}
15+
16+
S3TransferManagerConfiguration::S3TransferManagerConfiguration(const Aws::Client::ClientConfigurationInitValues& configuration)
17+
: BaseClientConfigClass(configuration) {
18+
LoadS3TransferManagerSpecificConfig(this->profileName);
19+
}
20+
21+
S3TransferManagerConfiguration::S3TransferManagerConfiguration(const char* inputProfileName, bool shouldDisableIMDS)
22+
: BaseClientConfigClass(inputProfileName, shouldDisableIMDS) {
23+
LoadS3TransferManagerSpecificConfig(Aws::String(inputProfileName));
24+
}
25+
26+
S3TransferManagerConfiguration::S3TransferManagerConfiguration(bool useSmartDefaults, const char* defaultMode, bool shouldDisableIMDS)
27+
: BaseClientConfigClass(useSmartDefaults, defaultMode, shouldDisableIMDS) {
28+
LoadS3TransferManagerSpecificConfig(this->profileName);
29+
}
30+
31+
S3TransferManagerConfiguration::S3TransferManagerConfiguration(const Aws::Client::ClientConfiguration& config)
32+
: BaseClientConfigClass(config) {
33+
LoadS3TransferManagerSpecificConfig(this->profileName);
34+
}
35+
36+
} // namespace Transfer
37+
} // namespace S3
38+
} // namespace Aws

0 commit comments

Comments
 (0)