adding a m_hasdeadline check to prevent invariant and address requestTimeoutMs = 0

Author: kai-ion

src/aws-cpp-sdk-core/include/aws/core/utils/stream/HttpWriteDataStreamBuf.h

@@ -36,7 +36,7 @@ namespace Stream {
  */
 class AWS_CORE_API HttpWriteDataStreamBuf : public std::streambuf {
  public:
-  explicit HttpWriteDataStreamBuf(const std::shared_ptr<Aws::Http::HttpClient>& client, size_t bufferLength = 8 * 1024, long requestTimeoutMs = 0);
+  explicit HttpWriteDataStreamBuf(const std::shared_ptr<Aws::Http::HttpClient>& client, size_t bufferLength = 8 * 1024, size_t requestTimeoutMs = 0);
   HttpWriteDataStreamBuf(const HttpWriteDataStreamBuf& other) = delete;
   HttpWriteDataStreamBuf(HttpWriteDataStreamBuf&& other) noexcept = delete;
   HttpWriteDataStreamBuf& operator=(const HttpWriteDataStreamBuf& other) = delete;

src/aws-cpp-sdk-core/source/utils/stream/HttpWriteDataStreamBuf.cpp

@@ -5,7 +5,6 @@
 #include <aws/core/http/HttpClient.h>
 #include <aws/core/utils/stream/HttpWriteDataStreamBuf.h>
 
-#include <cassert>
 #include <chrono>
 #include <utility>
 
@@ -15,9 +14,8 @@ const char* WRITE_DATA_BUF_LOG_NAME = "HttpWriteDataStreamBuf";
 
 Aws::Utils::Stream::HttpWriteDataStreamBuf::HttpWriteDataStreamBuf(const std::shared_ptr<Aws::Http::HttpClient>& client,
                                                                    size_t bufferLength,
-                                                                   long requestTimeoutMs)
+                                                                   size_t requestTimeoutMs)
     : m_client{client}, m_buffer{bufferLength} {
-  assert(requestTimeoutMs >= 0);
   if (requestTimeoutMs > 0) {
     m_hasDeadline = true;
     m_deadline = std::chrono::steady_clock::now() + std::chrono::milliseconds(requestTimeoutMs);