Add DynamoDB Streams retry tuning (25ms backoff, 4 max attempts)

  Per the Retry Behavior 2.1 SEP, DynamoDB Streams uses the same retry
  tuning as DynamoDB: 25ms transient backoff base and 4 max attempts.
  Generate a DynamoDBStreamsClientConfiguration class with the retry
  factory instead of using the GenericClientConfiguration typedef.

Author: kai-ion

generated/src/aws-cpp-sdk-dynamodb/source/DynamoDBClientConfiguration.cpp

@@ -38,10 +38,7 @@ void DynamoDBClientConfiguration::LoadDynamoDBSpecificConfig(const Aws::String&
     enableEndpointDiscovery = IsEndpointDiscoveryEnabled(this->endpointOverride, inputProfileName);
   }
   this->configFactories.retryStrategyCreateFn = []() -> std::shared_ptr<Client::RetryStrategy> {
-    // TODO: renable once default retries are evaluated
-    // Align with other SDKs to default retry to 10 times for dynamodb.
-    // return Client::InitRetryStrategy(10);
-    return Client::InitRetryStrategy();
+    return Client::InitRetryStrategy(4, "", 0.025);
   };
 }
 

generated/src/aws-cpp-sdk-dynamodbstreams/include/aws/dynamodbstreams/DynamoDBStreamsClientConfiguration.h

@@ -0,0 +1,43 @@
+/**
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0.
+ */
+
+#pragma once
+
+#include <aws/core/client/GenericClientConfiguration.h>
+#include <aws/dynamodbstreams/DynamoDBStreams_EXPORTS.h>
+
+namespace Aws {
+namespace DynamoDBStreams {
+struct AWS_DYNAMODBSTREAMS_API DynamoDBStreamsClientConfiguration : public Aws::Client::GenericClientConfiguration {
+  using BaseClientConfigClass = Aws::Client::GenericClientConfiguration;
+
+  DynamoDBStreamsClientConfiguration(const Aws::Client::ClientConfigurationInitValues& configuration = {});
+
+  /**
+   * Create a configuration based on settings in the aws configuration file for the given profile name.
+   * The configuration file location can be set via the environment variable AWS_CONFIG_FILE
+   * @param profileName the aws profile name.
+   * @param shouldDisableIMDS whether or not to disable IMDS calls.
+   */
+  DynamoDBStreamsClientConfiguration(const char* profileName, bool shouldDisableIMDS = false);
+
+  /**
+   * Create a configuration with a predefined smart defaults
+   * @param useSmartDefaults, required to differentiate c-tors
+   * @param defaultMode, default mode to use
+   * @param shouldDisableIMDS whether or not to disable IMDS calls.
+   */
+  DynamoDBStreamsClientConfiguration(bool useSmartDefaults, const char* defaultMode = "legacy", bool shouldDisableIMDS = false);
+
+  /**
+   * Converting constructors for compatibility with a legacy code
+   */
+  DynamoDBStreamsClientConfiguration(const Aws::Client::ClientConfiguration& config);
+
+ private:
+  void LoadDynamoDBStreamsSpecificConfig(const Aws::String& profileName);
+};
+}  // namespace DynamoDBStreams
+}  // namespace Aws

generated/src/aws-cpp-sdk-dynamodbstreams/include/aws/dynamodbstreams/DynamoDBStreamsEndpointProvider.h

@@ -4,25 +4,30 @@
  */
 
 #pragma once
-#include <aws/core/client/GenericClientConfiguration.h>
 #include <aws/core/endpoint/DefaultEndpointProvider.h>
 #include <aws/core/endpoint/EndpointParameter.h>
 #include <aws/core/utils/memory/stl/AWSString.h>
 #include <aws/core/utils/memory/stl/AWSVector.h>
+#include <aws/dynamodbstreams/DynamoDBStreamsClientConfiguration.h>
 #include <aws/dynamodbstreams/DynamoDBStreamsEndpointRules.h>
 #include <aws/dynamodbstreams/DynamoDBStreams_EXPORTS.h>
 
 namespace Aws {
 namespace DynamoDBStreams {
 namespace Endpoint {
+using DynamoDBStreamsClientConfiguration = Aws::DynamoDBStreams::DynamoDBStreamsClientConfiguration;
 using EndpointParameters = Aws::Endpoint::EndpointParameters;
 using Aws::Endpoint::DefaultEndpointProvider;
 using Aws::Endpoint::EndpointProviderBase;
 
 using DynamoDBStreamsClientContextParameters = Aws::Endpoint::ClientContextParameters;
 
-using DynamoDBStreamsClientConfiguration = Aws::Client::GenericClientConfiguration;
-using DynamoDBStreamsBuiltInParameters = Aws::Endpoint::BuiltInParameters;
+class AWS_DYNAMODBSTREAMS_API DynamoDBStreamsBuiltInParameters : public Aws::Endpoint::BuiltInParameters {
+ public:
+  virtual ~DynamoDBStreamsBuiltInParameters() {};
+  using Aws::Endpoint::BuiltInParameters::SetFromClientConfiguration;
+  virtual void SetFromClientConfiguration(const DynamoDBStreamsClientConfiguration& config);
+};
 
 /**
  * The type for the DynamoDBStreams Client Endpoint Provider.
@@ -35,6 +40,24 @@ using DynamoDBStreamsEndpointProviderBase =
 using DynamoDBStreamsDefaultEpProviderBase =
     DefaultEndpointProvider<DynamoDBStreamsClientConfiguration, DynamoDBStreamsBuiltInParameters, DynamoDBStreamsClientContextParameters>;
 
+}  // namespace Endpoint
+}  // namespace DynamoDBStreams
+
+namespace Endpoint {
+/**
+ * Export endpoint provider symbols for Windows DLL, otherwise declare as extern
+ */
+AWS_DYNAMODBSTREAMS_EXTERN template class AWS_DYNAMODBSTREAMS_API Aws::Endpoint::EndpointProviderBase<
+    DynamoDBStreams::Endpoint::DynamoDBStreamsClientConfiguration, DynamoDBStreams::Endpoint::DynamoDBStreamsBuiltInParameters,
+    DynamoDBStreams::Endpoint::DynamoDBStreamsClientContextParameters>;
+
+AWS_DYNAMODBSTREAMS_EXTERN template class AWS_DYNAMODBSTREAMS_API Aws::Endpoint::DefaultEndpointProvider<
+    DynamoDBStreams::Endpoint::DynamoDBStreamsClientConfiguration, DynamoDBStreams::Endpoint::DynamoDBStreamsBuiltInParameters,
+    DynamoDBStreams::Endpoint::DynamoDBStreamsClientContextParameters>;
+}  // namespace Endpoint
+
+namespace DynamoDBStreams {
+namespace Endpoint {
 /**
  * Default endpoint provider used for this service
  */

generated/src/aws-cpp-sdk-dynamodbstreams/include/aws/dynamodbstreams/DynamoDBStreamsServiceClientModel.h

@@ -51,7 +51,6 @@ class RetryStrategy;
 }  // namespace Client
 
 namespace DynamoDBStreams {
-using DynamoDBStreamsClientConfiguration = Aws::Client::GenericClientConfiguration;
 using DynamoDBStreamsEndpointProviderBase = Aws::DynamoDBStreams::Endpoint::DynamoDBStreamsEndpointProviderBase;
 using DynamoDBStreamsEndpointProvider = Aws::DynamoDBStreams::Endpoint::DynamoDBStreamsEndpointProvider;
 

generated/src/aws-cpp-sdk-dynamodbstreams/source/DynamoDBStreamsClientConfiguration.cpp

@@ -0,0 +1,44 @@
+/**
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0.
+ */
+
+#include <aws/dynamodbstreams/DynamoDBStreamsClientConfiguration.h>
+
+namespace Aws {
+namespace DynamoDBStreams {
+
+void DynamoDBStreamsClientConfiguration::LoadDynamoDBStreamsSpecificConfig(const Aws::String& inputProfileName) {
+  this->configFactories.retryStrategyCreateFn = []() -> std::shared_ptr<Client::RetryStrategy> {
+    return Client::InitRetryStrategy(4, "", 0.025);
+  };
+#if defined(_MSC_VER)
+  (&reinterpret_cast<const int&>(inputProfileName));
+#else
+  (void)(inputProfileName);
+#endif
+}
+
+DynamoDBStreamsClientConfiguration::DynamoDBStreamsClientConfiguration(const Aws::Client::ClientConfigurationInitValues& configuration)
+    : BaseClientConfigClass(configuration) {
+  LoadDynamoDBStreamsSpecificConfig(this->profileName);
+}
+
+DynamoDBStreamsClientConfiguration::DynamoDBStreamsClientConfiguration(const char* inputProfileName, bool shouldDisableIMDS)
+    : BaseClientConfigClass(inputProfileName, shouldDisableIMDS) {
+  LoadDynamoDBStreamsSpecificConfig(Aws::String(inputProfileName));
+}
+
+DynamoDBStreamsClientConfiguration::DynamoDBStreamsClientConfiguration(bool useSmartDefaults, const char* defaultMode,
+                                                                       bool shouldDisableIMDS)
+    : BaseClientConfigClass(useSmartDefaults, defaultMode, shouldDisableIMDS) {
+  LoadDynamoDBStreamsSpecificConfig(this->profileName);
+}
+
+DynamoDBStreamsClientConfiguration::DynamoDBStreamsClientConfiguration(const Aws::Client::ClientConfiguration& config)
+    : BaseClientConfigClass(config) {
+  LoadDynamoDBStreamsSpecificConfig(this->profileName);
+}
+
+}  // namespace DynamoDBStreams
+}  // namespace Aws

generated/src/aws-cpp-sdk-dynamodbstreams/source/DynamoDBStreamsEndpointProvider.cpp

@@ -6,7 +6,27 @@
 #include <aws/dynamodbstreams/DynamoDBStreamsEndpointProvider.h>
 
 namespace Aws {
+#ifndef AWS_DYNAMODBSTREAMS_EXPORTS  // Except for Windows DLL
+namespace Endpoint {
+/**
+ * Instantiate endpoint providers
+ */
+template class Aws::Endpoint::EndpointProviderBase<DynamoDBStreams::Endpoint::DynamoDBStreamsClientConfiguration,
+                                                   DynamoDBStreams::Endpoint::DynamoDBStreamsBuiltInParameters,
+                                                   DynamoDBStreams::Endpoint::DynamoDBStreamsClientContextParameters>;
+
+template class Aws::Endpoint::DefaultEndpointProvider<DynamoDBStreams::Endpoint::DynamoDBStreamsClientConfiguration,
+                                                      DynamoDBStreams::Endpoint::DynamoDBStreamsBuiltInParameters,
+                                                      DynamoDBStreams::Endpoint::DynamoDBStreamsClientContextParameters>;
+}  // namespace Endpoint
+#endif
+
 namespace DynamoDBStreams {
-namespace Endpoint {}  // namespace Endpoint
+namespace Endpoint {
+void DynamoDBStreamsBuiltInParameters::SetFromClientConfiguration(const DynamoDBStreamsClientConfiguration& config) {
+  SetFromClientConfiguration(static_cast<const DynamoDBStreamsClientConfiguration::BaseClientConfigClass&>(config));
+}
+
+}  // namespace Endpoint
 }  // namespace DynamoDBStreams
 }  // namespace Aws

generated/src/aws-cpp-sdk-sqs/source/SQSClient.cpp

@@ -275,6 +275,9 @@ PurgeQueueOutcome SQSClient::PurgeQueue(const PurgeQueueRequest& request) const
 }
 
 ReceiveMessageOutcome SQSClient::ReceiveMessage(const ReceiveMessageRequest& request) const {
+  auto longPollParams = Aws::MakeShared<Aws::Http::ServiceSpecificParameters>("SQSClient");
+  longPollParams->parameterMap.emplace("isLongPollingOperation", "true");
+  request.SetServiceSpecificParameters(longPollParams);
   auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
   return result.IsSuccess() ? ReceiveMessageOutcome(result.GetResultWithOwnership()) : ReceiveMessageOutcome(std::move(result.GetError()));
 }

generated/src/aws-cpp-sdk-states/source/SFNClient.cpp

@@ -283,6 +283,9 @@ DescribeStateMachineForExecutionOutcome SFNClient::DescribeStateMachineForExecut
 }
 
 GetActivityTaskOutcome SFNClient::GetActivityTask(const GetActivityTaskRequest& request) const {
+  auto longPollParams = Aws::MakeShared<Aws::Http::ServiceSpecificParameters>("SFNClient");
+  longPollParams->parameterMap.emplace("isLongPollingOperation", "true");
+  request.SetServiceSpecificParameters(longPollParams);
   auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
   return result.IsSuccess() ? GetActivityTaskOutcome(result.GetResultWithOwnership())
                             : GetActivityTaskOutcome(std::move(result.GetError()));

generated/src/aws-cpp-sdk-swf/source/SWFClient.cpp

@@ -327,12 +327,18 @@ ListWorkflowTypesOutcome SWFClient::ListWorkflowTypes(const ListWorkflowTypesReq
 }
 
 PollForActivityTaskOutcome SWFClient::PollForActivityTask(const PollForActivityTaskRequest& request) const {
+  auto longPollParams = Aws::MakeShared<Aws::Http::ServiceSpecificParameters>("SWFClient");
+  longPollParams->parameterMap.emplace("isLongPollingOperation", "true");
+  request.SetServiceSpecificParameters(longPollParams);
   auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
   return result.IsSuccess() ? PollForActivityTaskOutcome(result.GetResultWithOwnership())
                             : PollForActivityTaskOutcome(std::move(result.GetError()));
 }
 
 PollForDecisionTaskOutcome SWFClient::PollForDecisionTask(const PollForDecisionTaskRequest& request) const {
+  auto longPollParams = Aws::MakeShared<Aws::Http::ServiceSpecificParameters>("SWFClient");
+  longPollParams->parameterMap.emplace("isLongPollingOperation", "true");
+  request.SetServiceSpecificParameters(longPollParams);
   auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
   return result.IsSuccess() ? PollForDecisionTaskOutcome(result.GetResultWithOwnership())
                             : PollForDecisionTaskOutcome(std::move(result.GetError()));

generated/tests/dynamodbstreams-gen-tests/DynamoDBStreamsIncludeTests.cpp

@@ -7,6 +7,7 @@
 #include <aws/testing/AwsTestHelpers.h>
 
 #include <aws/dynamodbstreams/DynamoDBStreamsClient.h>
+#include <aws/dynamodbstreams/DynamoDBStreamsClientConfiguration.h>
 #include <aws/dynamodbstreams/DynamoDBStreamsEndpointProvider.h>
 #include <aws/dynamodbstreams/DynamoDBStreamsEndpointRules.h>
 #include <aws/dynamodbstreams/DynamoDBStreamsErrorMarshaller.h>