Clean up obj property name and improve error creation (#551)

Author: satyakigh

src/services/cfnLint/CfnLintErrors.ts

@@ -1,16 +1,17 @@
 export class WorkerNotInitializedError extends Error {
-    constructor(message: string = 'Worker not initialized') {
-        super(message);
+    constructor(message: string = 'Worker not initialized', options?: ErrorOptions) {
+        super(message, options);
         this.name = 'WorkerNotInitializedError';
+        Object.setPrototypeOf(this, WorkerNotInitializedError.prototype);
     }
 }
 
 export class MountError extends Error {
     public override readonly cause?: Error;
 
-    constructor(message: string, cause?: Error) {
-        super(message);
+    constructor(message: string, options?: ErrorOptions) {
+        super(message, options);
         this.name = 'MountError';
-        this.cause = cause;
+        Object.setPrototypeOf(this, MountError.prototype);
     }
 }

src/utils/Delayer.ts

@@ -1,7 +1,8 @@
 export class CancellationError extends Error {
-    constructor(key: string) {
-        super(`Request cancelled for key: ${key}`);
+    constructor(key: string, options?: ErrorOptions) {
+        super(`Request cancelled for key: ${key}`, options);
         this.name = 'CancellationError';
+        Object.setPrototypeOf(this, CancellationError.prototype);
     }
 }
 

tst/unit/datastore/FileStore.test.ts

@@ -272,7 +272,7 @@ describe('FileStore', () => {
             expect(readdirSync(encTestDir)).toEqual([]);
 
             await store.put('key', 'someValue');
-            expect(readdirSync(encTestDir)).toEqual([encodedFilePath(encTestDir, 'test', 'key').relPath]);
+            expect(readdirSync(encTestDir)).toEqual([encodedFilePath(encTestDir, 'test', 'key').fileName]);
         });
     });
 
@@ -587,6 +587,6 @@ function encodedFilePath(dir: string, store: string, key: string) {
     const filePath = join(dir, `${store}.${stableHashCode(key)}.enc`);
     return {
         filePath,
-        relPath: basename(filePath),
+        fileName: basename(filePath),
     };
 }