Now that we properly test the precompiles:
Not for this PR, but is it possible to achieve the same test effect coverage by using the WarpTest.sol (and corresponding ABI/bindings) in vm_warp_test.go? If so, we could remove the ExampleWarp files all together.
I think this should be possible and pretty straightforward. The only difference is that require statements in validateWarpMessage below will need to made by the test itself, but I think that is a good change to make because otherwise the test is actually testing the example contract implementation rather than the VM behavior itself.
If you agree, could you create an issue for this? Definitely not a priority right now but don't want to lose track of it.
Originally posted by @michaelkaplan13 in ava-labs/subnet-evm#1907 (comment)
Now that we properly test the precompiles:
Not for this PR, but is it possible to achieve the same test effect coverage by using the
WarpTest.sol(and corresponding ABI/bindings) invm_warp_test.go? If so, we could remove theExampleWarpfiles all together.I think this should be possible and pretty straightforward. The only difference is that
requirestatements invalidateWarpMessagebelow will need to made by the test itself, but I think that is a good change to make because otherwise the test is actually testing the example contract implementation rather than the VM behavior itself.If you agree, could you create an issue for this? Definitely not a priority right now but don't want to lose track of it.
Originally posted by @michaelkaplan13 in ava-labs/subnet-evm#1907 (comment)