From e51345055456c118bc63ef59332f1382e02cf9e1 Mon Sep 17 00:00:00 2001 From: Robin Bolscher Date: Wed, 8 Jul 2026 16:11:24 +0200 Subject: [PATCH] chore: require Node.js 24 homey-api@3.17.7 declares engines.node >=24, so the effective runtime floor is Node 24 even though package.json still said >=22. Bump engines.node to >=24 and add an .nvmrc pinned to 24 as the single source of truth. CI workflows now read the version via node-version-file: .nvmrc instead of hardcoding it. --- .github/workflows/lint.yml | 2 +- .github/workflows/npm-version.yml | 4 ++-- .github/workflows/publish-package-npm.yml | 2 +- .github/workflows/test.yml | 2 +- .github/workflows/update-homey-lib.yml | 4 ++-- .nvmrc | 1 + package-lock.json | 2 +- package.json | 2 +- 8 files changed, 10 insertions(+), 9 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 91ade285..bfb2c398 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -32,7 +32,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '22' + node-version-file: '.nvmrc' cache: npm registry-url: 'https://npm.pkg.github.com' diff --git a/.github/workflows/npm-version.yml b/.github/workflows/npm-version.yml index 3d46ee16..aebcf807 100644 --- a/.github/workflows/npm-version.yml +++ b/.github/workflows/npm-version.yml @@ -33,10 +33,10 @@ jobs: with: token: ${{ secrets.HOMEY_GITHUB_ACTIONS_BOT_PERSONAL_ACCESS_TOKEN }} - - name: Set up node 22 environment + - name: Set up node environment uses: actions/setup-node@v4 with: - node-version: '22' + node-version-file: '.nvmrc' registry-url: 'https://npm.pkg.github.com' - name: Version diff --git a/.github/workflows/publish-package-npm.yml b/.github/workflows/publish-package-npm.yml index d549371d..483ffbef 100644 --- a/.github/workflows/publish-package-npm.yml +++ b/.github/workflows/publish-package-npm.yml @@ -39,7 +39,7 @@ jobs: - name: Set up node uses: actions/setup-node@v4 with: - node-version: '24' + node-version-file: '.nvmrc' registry-url: 'https://npm.pkg.github.com' # Sets package.json name & version to environment. diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index bb25ed04..16ac10c2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,7 +17,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '22' + node-version-file: '.nvmrc' cache: npm registry-url: 'https://npm.pkg.github.com' diff --git a/.github/workflows/update-homey-lib.yml b/.github/workflows/update-homey-lib.yml index cf071d10..ca5b43b6 100644 --- a/.github/workflows/update-homey-lib.yml +++ b/.github/workflows/update-homey-lib.yml @@ -33,10 +33,10 @@ jobs: git config --local user.name "Homey Github Actions Bot" # Configures a Node.js environment. - - name: Set up node 22 environment + - name: Set up node environment uses: actions/setup-node@v4 with: - node-version: '22' + node-version-file: '.nvmrc' # Needed for publishing to npm registry-url: 'https://registry.npmjs.org' diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 00000000..a45fd52c --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +24 diff --git a/package-lock.json b/package-lock.json index 36018a10..710b021f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -50,7 +50,7 @@ "prettier": "^3.8.1" }, "engines": { - "node": ">=22" + "node": ">=24" } }, "node_modules/@anthropic-ai/sdk": { diff --git a/package.json b/package.json index 77d0f64a..9fdc5280 100644 --- a/package.json +++ b/package.json @@ -23,7 +23,7 @@ "homey": "bin/homey.mjs" }, "engines": { - "node": ">=22" + "node": ">=24" }, "repository": { "url": "https://github.com/athombv/node-homey"