Merge branch 'OUT-4000-filter-iu-email-by-preference' of https://github.com/assemblycom/tasks-app into staging

Author: arpandhakal

src/app/api/notification/iuEmailPreference.test.ts

@@ -1,5 +1,5 @@
 import { InternalUserNotificationSettings } from '@/types/common'
-import { disabledEmailSettingIds, isIuEmailGloballyOff } from './iuEmailPreference'
+import { disabledEmailSettingIds } from './iuEmailPreference'
 
 const settings = (overrides: Partial<InternalUserNotificationSettings> = {}): InternalUserNotificationSettings => ({
   emailSettings: 'active',
@@ -44,18 +44,3 @@ describe('disabledEmailSettingIds', () => {
     ).toEqual(new Set())
   })
 })
-
-describe('isIuEmailGloballyOff', () => {
-  it('is false only when emailSettings is explicitly active (case-insensitive)', () => {
-    expect(isIuEmailGloballyOff(settings({ emailSettings: 'active' }))).toBe(false)
-    expect(isIuEmailGloballyOff(settings({ emailSettings: 'Active' }))).toBe(false)
-    expect(isIuEmailGloballyOff(settings({ emailSettings: ' ACTIVE ' }))).toBe(false)
-  })
-
-  it('fails closed for any non-active value so a global opt-out is never bypassed', () => {
-    expect(isIuEmailGloballyOff(settings({ emailSettings: 'not_active' }))).toBe(true)
-    expect(isIuEmailGloballyOff(settings({ emailSettings: 'disabled' }))).toBe(true)
-    expect(isIuEmailGloballyOff(settings({ emailSettings: undefined }))).toBe(true)
-    expect(isIuEmailGloballyOff(settings({ emailSettings: '' }))).toBe(true)
-  })
-})

src/app/api/notification/iuEmailPreference.ts

@@ -8,9 +8,3 @@ export const disabledEmailSettingIds = (settings: InternalUserNotificationSettin
     .map((entry) => entry.notificationSettingId as string)
   return new Set(ids)
 }
-
-// Global email gate, fail-closed: email is delivered only when the IU has explicitly activated
-// email notifications. Any other value — a different disabled string, unexpected casing, or a
-// missing field — is treated as not activated, so a global opt-out is never bypassed.
-export const isIuEmailGloballyOff = (settings: InternalUserNotificationSettings): boolean =>
-  (settings.emailSettings ?? '').trim().toLowerCase() !== 'active'

src/jobs/notifications/flush-grouped-email.test.ts

@@ -202,17 +202,6 @@ describe('flushGroupedEmailRun', () => {
     expect(result).toMatchObject({ recipients: 1, sent: 0, sentGrouped: 0, sentIndividual: 0 })
   })
 
-  it('sends nothing to an IU whose email is globally not active', async () => {
-    mockGetIuNotificationSettings.mockResolvedValue({ emailSettings: 'not_active', notifyAbout: {} })
-    mockQueryRaw.mockResolvedValue([iuRow('setting_assigned'), iuRow('setting_comment')])
-
-    const result = await flushGroupedEmailRun(payload)
-
-    expect(mockSendGroupedEmail).not.toHaveBeenCalled()
-    expect(mockCreateNotification).not.toHaveBeenCalled()
-    expect(result).toMatchObject({ sent: 0 })
-  })
-
   it('sends ungated when the IU preference read fails (fail-open)', async () => {
     mockGetIuNotificationSettings.mockRejectedValue(new Error('copilot 5xx'))
     mockQueryRaw.mockResolvedValue([iuRow('setting_comment'), iuRow('setting_comment')])

src/jobs/notifications/flush-grouped-email.ts

@@ -3,7 +3,7 @@ import 'server-only'
 import { randomUUID } from 'crypto'
 
 import { composeGroupedEmail, GroupedEmailEventInput } from '@/app/api/notification/groupedEmail.composer'
-import { disabledEmailSettingIds, isIuEmailGloballyOff } from '@/app/api/notification/iuEmailPreference'
+import { disabledEmailSettingIds } from '@/app/api/notification/iuEmailPreference'
 import { copilotAPIKey } from '@/config'
 import { Sentry } from '@/jobs/sentry'
 import DBClient from '@/lib/db'
@@ -99,7 +99,6 @@ const filterEventsForIuPreferences = async (
 ): Promise<WindowEvent[]> => {
   try {
     const settings = await copilot.getInternalUserNotificationSettings(recipientIuId)
-    if (isIuEmailGloballyOff(settings)) return []
     const disabled = disabledEmailSettingIds(settings)
     return events.filter((e) => {
       const id = e.individualEmail?.notificationSettingId