chore(notifications): ship IU notifications ungated for now

Stop attaching notificationSettingId (set undefined; resolve calls commented) so IUs
receive all email + in-product notifications without platform gating. Per-IU gating
is blocked on Copilot exposing a preference-read endpoint; re-enable by restoring the
commented resolve calls (and implementing flush-time preference filtering).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: arpandhakal

src/app/api/notification/notification.service.test.ts

@@ -432,20 +432,21 @@ describe('guard: IU wiring boundaries', () => {
   })
 })
 
-describe('guard: IU notification setting gating', () => {
-  it('resolves the id by action category and attaches it to both the buffered email and the in-product dispatch', async () => {
+describe('guard: IU notifications ship ungated (settingId gating disabled)', () => {
+  it('does not attach notificationSettingId to the in-product dispatch or the buffered email', async () => {
     const task = makeTask({ assigneeType: AssigneeType.internalUser, clientId: null })
     await buildService().create(NotificationTaskActions.Assigned, task, { disableEmail: false })
 
-    expect(mockGroupedCreateMany.mock.calls[0][0].data[0].individualEmail.notificationSettingId).toBe('setting_assigned')
-    expect(mockCreateNotification.mock.calls[0][0].notificationSettingId).toBe('setting_assigned')
+    expect(mockCreateNotification.mock.calls[0][0].notificationSettingId).toBeUndefined()
+    expect(mockGroupedCreateMany.mock.calls[0][0].data[0].individualEmail.notificationSettingId).toBeUndefined()
   })
 
-  it('resolves a different id per category (COMPLETED vs ASSIGNED)', async () => {
+  it('still buffers the IU email and fires the in-product notification', async () => {
     const task = makeTask({ assigneeType: AssigneeType.internalUser, clientId: null })
-    await buildService().create(NotificationTaskActions.CompletedByIU, task, { disableEmail: false })
+    await buildService().create(NotificationTaskActions.Assigned, task, { disableEmail: false })
 
-    expect(mockCreateNotification.mock.calls[0][0].notificationSettingId).toBe('setting_completed')
+    expect(mockGroupedCreateMany).toHaveBeenCalledTimes(1)
+    expect(deliveryTargetsOf(0).inProduct).toBeDefined()
   })
 
   it('keeps IU grouped windows cross-category (window key is not scoped by event type)', async () => {
@@ -455,17 +456,6 @@ describe('guard: IU notification setting gating', () => {
     expect(mockGroupedCreateMany.mock.calls[0][0].data[0].windowKey).toMatch(new RegExp(`^${task.assigneeId}:iu:[^:]+$`))
   })
 
-  it('still buffers the IU email but attaches no id when the category is not declared (gating deferred to flush)', async () => {
-    mockGetNotificationSettings.mockResolvedValue({ notifications: [] })
-    const task = makeTask({ assigneeType: AssigneeType.internalUser, clientId: null })
-    await buildService().create(NotificationTaskActions.Assigned, task, { disableEmail: false })
-
-    expect(mockGroupedCreateMany).toHaveBeenCalledTimes(1)
-    expect(mockGroupedCreateMany.mock.calls[0][0].data[0].individualEmail.notificationSettingId).toBeUndefined()
-    expect(mockCreateNotification.mock.calls[0][0].notificationSettingId).toBeUndefined()
-    expect(deliveryTargetsOf(0).inProduct).toBeDefined()
-  })
-
   it('treats a suppressed (null) createNotification response as a no-op — no throw, no save', async () => {
     // Platform dropped the only requested surface for this IU (preference off) → no created object.
     mockCreateNotification.mockResolvedValue(null)

src/app/api/notification/notification.service.ts

@@ -14,7 +14,7 @@ import APIError from '@api/core/exceptions/api'
 import { BaseService } from '@api/core/services/base.service'
 import { NotificationTaskActions } from '@api/core/types/tasks'
 import { getEmailDetails, getInProductNotificationDetails, mergeEmailOverride } from '@api/notification/notification.helpers'
-import { resolveIuNotificationSettingId } from '@api/notification/resolveNotificationSettingId'
+// import { resolveIuNotificationSettingId } from '@api/notification/resolveNotificationSettingId'
 import { AssigneeType, ClientNotification, GroupedEmailEventType, Prisma, Task } from '@prisma/client'
 import { randomUUID } from 'crypto'
 import { enqueueGroupedEmailFlush } from '@/jobs/notifications/flush-grouped-email'
@@ -74,13 +74,9 @@ export class NotificationService extends BaseService {
       const email = baseEmail ? mergeEmailOverride({ base: baseEmail, override: opts.emailOverride }) : baseEmail
 
       const category = this.groupedEventTypeFor(action)
-      // IU sends carry the category's setting id. It gates the in-product surface per the IU's
-      // preference immediately, and rides along on the buffered email so a single-category grouped
-      // flush can gate the email too (see flush-grouped-email).
-      const notificationSettingId =
-        isRecipientIu && category
-          ? await resolveIuNotificationSettingId({ copilot: this.copilot, workspaceId: task.workspaceId, category })
-          : undefined
+      // Gating disabled until Copilot exposes a per-IU preference read endpoint — ship IUs ungated.
+      const notificationSettingId = undefined
+      // const notificationSettingId = isRecipientIu && category ? await resolveIuNotificationSettingId({ copilot: this.copilot, workspaceId: task.workspaceId, category }) : undefined
 
       const groupedType = email && recipientId ? category : null
       if (groupedType) {
@@ -210,12 +206,9 @@ export class NotificationService extends BaseService {
       const association = AssociationsSchema.parse(task.associations)?.[0]
       const category = this.groupedEventTypeFor(action)
       const isRecipientIu = opts.isRecipientIu
-      // Resolve once per batch (not per recipient). The id gates the in-product surface per IU and
-      // rides along on the buffered email for the flush-time single-category gate (see create()).
-      const notificationSettingId =
-        isRecipientIu && category
-          ? await resolveIuNotificationSettingId({ copilot: this.copilot, workspaceId: task.workspaceId, category })
-          : undefined
+      // Gating disabled until Copilot exposes a per-IU preference read endpoint — ship IUs ungated.
+      const notificationSettingId = undefined
+      // const notificationSettingId = isRecipientIu && category ? await resolveIuNotificationSettingId({ copilot: this.copilot, workspaceId: task.workspaceId, category }) : undefined
       // Non-null only when these emails should be diverted into the grouped buffer.
       const groupedType = email ? category : null
 

src/jobs/notifications/send-reply-create-notifications.ts

@@ -6,7 +6,7 @@ import { isMessagableError } from '@/utils/copilotError'
 import { CommentRepository } from '@/app/api/comments/comment.repository'
 import { CommentService } from '@/app/api/comments/comment.service'
 import { NotificationService } from '@/app/api/notification/notification.service'
-import { resolveIuNotificationSettingId } from '@/app/api/notification/resolveNotificationSettingId'
+// import { resolveIuNotificationSettingId } from '@/app/api/notification/resolveNotificationSettingId'
 import User from '@api/core/models/User.model'
 import { TasksService } from '@api/tasks/tasks.service'
 import { Comment, CommentInitiator, GroupedEmailEventType, Task } from '@prisma/client'
@@ -49,14 +49,10 @@ export const sendReplyCreateNotifications = task({
 
     const deliveryTargets = await getNotificationDetails(copilot, user, comment)
 
-    // Replies are the COMMENT category. Reply emails are buffered as COMMENT grouped events (like
-    // top-level comments), and IU sends carry this setting id so the platform gates each surface per
-    // the recipient IU's preference.
-    const notificationSettingId = await resolveIuNotificationSettingId({
-      copilot,
-      workspaceId: user.workspaceId,
-      category: GroupedEmailEventType.COMMENT,
-    })
+    // Replies are buffered as COMMENT grouped events like top-level comments.
+    // Gating disabled until Copilot exposes a per-IU preference read endpoint — ship IUs ungated.
+    const notificationSettingId = undefined
+    // const notificationSettingId = await resolveIuNotificationSettingId({ copilot, workspaceId: user.workspaceId, category: GroupedEmailEventType.COMMENT })
 
     const notificationPromises: Promise<unknown>[] = []
     const queueNotificationPromise = (promise: Promise<unknown>): void => {