OUT-4093 | Drop the Storage Access API gate on the assignee cache

hasStorageAccess() reports access to unpartitioned *cookies*; the cache
lives in IndexedDB, so it was the wrong signal. MDN documents it returning
false in browsers that don't block third-party access by default, which sent
us into requestStorageAccess() — automatically denied without a user gesture,
and there is none during AssigneeCacheGetter's mount effect. Net effect: the
gate disabled the cache for the users it was meant to protect, and threw on
Chrome 111, which predates the API.

The surrounding try/catch already degrades to a network fetch when storage is
genuinely denied, which is what MDN recommends instead of the gate.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: priosshrsth

src/app/_cache/forageStorage.test.ts

@@ -0,0 +1,45 @@
+const mockGetItem = jest.fn()
+const mockSetItem = jest.fn()
+
+jest.mock('localforage', () => ({
+  __esModule: true,
+  default: {
+    config: jest.fn(),
+    getItem: (...args: unknown[]) => mockGetItem(...args),
+    setItem: (...args: unknown[]) => mockSetItem(...args),
+  },
+}))
+
+import { getAssignees, setAssignees } from '@/app/_cache/forageStorage'
+
+const denied = () => new DOMException('Access is denied for this document.', 'SecurityError')
+
+describe('assignee cache', () => {
+  beforeAll(() => {
+    globalThis.window = {} as Window & typeof globalThis
+  })
+  afterAll(() => {
+    delete (globalThis as { window?: unknown }).window
+  })
+  beforeEach(() => jest.clearAllMocks())
+
+  it('returns an empty list when storage access is denied', async () => {
+    mockGetItem.mockRejectedValue(denied())
+
+    await expect(getAssignees('lookup-key')).resolves.toEqual([])
+    expect(mockGetItem).toHaveBeenCalledWith('assignees.lookup-key')
+  })
+
+  it('swallows write failures when storage access is denied', async () => {
+    mockSetItem.mockRejectedValue(denied())
+
+    await expect(setAssignees('lookup-key', [])).resolves.toBeUndefined()
+    expect(mockSetItem).toHaveBeenCalledWith('assignees.lookup-key', [])
+  })
+
+  it('returns an empty list when nothing is cached', async () => {
+    mockGetItem.mockResolvedValue(null)
+
+    await expect(getAssignees('lookup-key')).resolves.toEqual([])
+  })
+})

src/app/_cache/forageStorage.ts

@@ -12,33 +12,19 @@ export async function getAssignees(lookupKey: string): Promise<IAssigneeCombined
   if (typeof window === 'undefined') return []
 
   try {
-    if (!(await document.hasStorageAccess())) {
-      console.info('Browswer has no storage access')
-      await document.requestStorageAccess()
-    }
-
     return (await localforage.getItem<IAssigneeCombined[]>(`assignees.${lookupKey}`)) ?? []
   } catch (error: unknown) {
-    console.error(
-      "Storage access not granted. Under Chrome's Settings > Privacy and Security, make sure 'Third-party cookies' is allowed.",
-    )
+    console.info('Assignee cache unavailable, falling back to network', error)
     return []
   }
 }
 
-export async function setAssignees(lookupKey: string, value: any) {
+export async function setAssignees(lookupKey: string, value: IAssigneeCombined[]) {
   if (typeof window === 'undefined') return
 
   try {
-    if (!(await document.hasStorageAccess())) {
-      console.info('Browswer has no storage access')
-      await document.requestStorageAccess()
-    }
-
     return await localforage.setItem(`assignees.${lookupKey}`, value)
   } catch (error: unknown) {
-    console.error(
-      "Storage access not granted. Under Chrome's Settings > Privacy and Security, make sure 'Third-party cookies' is allowed.",
-    )
+    console.info('Assignee cache write skipped, storage unavailable', error)
   }
 }