refactor(OUT-3617): remove undepositedFundsAccountRef column and caching

Undeposited Funds is a QBO system account that always exists and cannot
be deleted. Caching its ID in qb_portal_connections was unnecessary.

- Add getUndepositedFundsAccountId() on IntuitAPI (live lookup by subtype)
- Call it directly in invoice.service.ts instead of checkAndUpdateAccountStatus
- Remove undepositedFundsAccountRef from schema, type, and all plumbing
- Remove UndepositedFunds from AccountTypeObj, updateAccountMapping, restoreAccountRef
- Reuse single IntuitAPI instance in webhookInvoicePaid
- Update migration: drop undeposited_funds_account_ref column addition

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: SandipBajracharya

src/action/quickbooks.action.ts

@@ -65,7 +65,6 @@ export async function checkForNonUsCompany(portalId: string) {
         assetAccountRef: portalConnection.assetAccountRef,
         serviceItemRef: portalConnection.serviceItemRef,
         clientFeeRef: portalConnection.clientFeeRef,
-        undepositedFundsAccountRef: portalConnection.undepositedFundsAccountRef,
         bankAccountRef: portalConnection.bankAccountRef,
       }
 

src/app/api/quickbooks/auth/auth.service.ts

@@ -139,8 +139,6 @@ export class AuthService extends BaseService {
         assetAccountRef: insertPayload.assetAccountRef,
         serviceItemRef: existingToken?.serviceItemRef || null,
         clientFeeRef: existingToken?.clientFeeRef || null,
-        undepositedFundsAccountRef:
-          existingToken?.undepositedFundsAccountRef || null,
         bankAccountRef: existingToken?.bankAccountRef || null,
       })
       // handle accounts
@@ -241,7 +239,6 @@ export class AuthService extends BaseService {
       setting,
       serviceItemRef,
       clientFeeRef,
-      undepositedFundsAccountRef,
       bankAccountRef,
       isSuspended,
     } = portalQBToken
@@ -265,7 +262,6 @@ export class AuthService extends BaseService {
       assetAccountRef: '',
       serviceItemRef: '',
       clientFeeRef: '',
-      undepositedFundsAccountRef: null,
       bankAccountRef: null,
     }
 
@@ -288,7 +284,6 @@ export class AuthService extends BaseService {
       assetAccountRef,
       serviceItemRef,
       clientFeeRef,
-      undepositedFundsAccountRef,
       bankAccountRef,
     }
 

src/app/api/quickbooks/invoice/invoice.service.ts

@@ -900,16 +900,11 @@ export class InvoiceService extends BaseService {
       setting?.bankDepositFeeFlag &&
       isPortalInBankDepositABTest(this.user.workspaceId)
 
+    const intuitApi = new IntuitAPI(qbTokenInfo)
+
     let depositToAccountRef: { value: string } | undefined
     if (useBankDepositFlow) {
-      const tokenService = new TokenService(this.user)
-      const undepositedFundsRef =
-        await tokenService.checkAndUpdateAccountStatus(
-          AccountTypeObj.UndepositedFunds,
-          qbTokenInfo.intuitRealmId,
-          new IntuitAPI(qbTokenInfo),
-          qbTokenInfo.undepositedFundsAccountRef ?? undefined,
-        )
+      const undepositedFundsRef = await intuitApi.getUndepositedFundsAccountId()
       depositToAccountRef = { value: undepositedFundsRef }
     }
 
@@ -933,7 +928,6 @@ export class InvoiceService extends BaseService {
         },
       ],
     }
-    const intuitApi = new IntuitAPI(qbTokenInfo)
     const paymentService = new PaymentService(this.user)
 
     const customerDisplayName =

src/app/api/quickbooks/token/token.service.ts

@@ -156,9 +156,6 @@ export class TokenService extends BaseService {
       case AccountTypeObj.Asset:
         payload = { assetAccountRef: accountRef }
         break
-      case AccountTypeObj.UndepositedFunds:
-        payload = { undepositedFundsAccountRef: accountRef }
-        break
       default:
         throw new APIError(
           httpStatus.BAD_REQUEST,
@@ -269,29 +266,6 @@ export class TokenService extends BaseService {
     return assetAccRef.Id
   }
 
-  private async getUndepositedFundsAccRef(
-    intuitApi: IntuitAPI,
-  ): Promise<string> {
-    // QBO enforces exactly one UndepositedFunds account per company — cannot create a second.
-    // Look up by subtype first (most reliable, works even if user renamed the account).
-    const query = `SELECT Id FROM Account WHERE AccountSubType = 'UndepositedFunds' AND Active = true maxresults 1`
-    const result = await intuitApi.customQuery(query)
-    if (result?.Account?.[0]?.Id) {
-      return result.Account[0].Id
-    }
-
-    // Fallback: try by default name
-    const byName = await intuitApi.getAnAccount('Undeposited Funds')
-    if (byName?.Id) {
-      return byName.Id
-    }
-
-    throw new APIError(
-      httpStatus.INTERNAL_SERVER_ERROR,
-      'TokenService#getUndepositedFundsAccRef | Undeposited Funds account not found in QuickBooks',
-    )
-  }
-
   private async restoreAccountRef(
     accountType: AccountType,
     intuitApi: IntuitAPI,
@@ -303,8 +277,6 @@ export class TokenService extends BaseService {
         return this.getOrCreateExpenseAccountRef(intuitApi)
       case AccountTypeObj.Asset:
         return this.getOrCreateAssetAccountRef(intuitApi)
-      case AccountTypeObj.UndepositedFunds:
-        return this.getUndepositedFundsAccRef(intuitApi)
       default:
         throw new APIError(
           httpStatus.BAD_REQUEST,

src/cmd/renameQbAccount/renameQbAccount.service.ts

@@ -161,7 +161,6 @@ export class RenameQbAccountService extends BaseService {
         assetAccountRef: portal.assetAccountRef,
         serviceItemRef: portal.serviceItemRef,
         clientFeeRef: portal.clientFeeRef,
-        undepositedFundsAccountRef: portal.undepositedFundsAccountRef,
         bankAccountRef: portal.bankAccountRef,
       }
     }

src/constant/qbConnection.ts

@@ -2,5 +2,4 @@ export const AccountTypeObj = {
   Income: 'income',
   Expense: 'expense',
   Asset: 'asset',
-  UndepositedFunds: 'undepositedFunds',
 } as const

src/db/migrations/20260417071636_add_bank_deposite_fee_column.sql

@@ -0,0 +1,2 @@
+ALTER TABLE "qb_portal_connections" ADD COLUMN "bank_account_ref" varchar(100);--> statement-breakpoint
+ALTER TABLE "qb_settings" ADD COLUMN "bank_deposit_fee_flag" boolean DEFAULT false NOT NULL;

src/db/migrations/20260420090412_add_bank_deposit_fee_column.sql

@@ -1,5 +1,5 @@
 {
-  "id": "dbeaa706-8b28-4714-9dca-aab6516ff0d5",
+  "id": "9eb854f3-0544-46b9-8b4f-6ad7457aaac9",
   "prevId": "1c9fbc27-72b3-4a6e-860c-6e3f247135d5",
   "version": "7",
   "dialect": "postgresql",
@@ -468,12 +468,6 @@
           "primaryKey": false,
           "notNull": false
         },
-        "undeposited_funds_account_ref": {
-          "name": "undeposited_funds_account_ref",
-          "type": "varchar(100)",
-          "primaryKey": false,
-          "notNull": false
-        },
         "bank_account_ref": {
           "name": "bank_account_ref",
           "type": "varchar(100)",
@@ -966,8 +960,7 @@
         "deleted",
         "succeeded",
         "mapped",
-        "unmapped",
-        "deposited"
+        "unmapped"
       ]
     },
     "public.failed_record_category_types": {

…ations/meta/20260417071636_snapshot.json …ations/meta/20260420090412_snapshot.jsonsrc/db/migrations/meta/20260417071636_snapshot.json renamed to src/db/migrations/meta/20260420090412_snapshot.json src/db/migrations/meta/20260417071636_snapshot.json renamed to src/db/migrations/meta/20260420090412_snapshot.json

@@ -117,8 +117,8 @@
     {
       "idx": 16,
       "version": "7",
-      "when": 1776410196223,
-      "tag": "20260417071636_add_bank_deposite_fee_column",
+      "when": 1776675852536,
+      "tag": "20260420090412_add_bank_deposit_fee_column",
       "breakpoints": true
     }
   ]