refactor(OUT-3545): use meaningful function name

Author: SandipBajracharya

src/app/api/quickbooks/product/flatten/route.ts

@@ -1,6 +1,6 @@
 import { withErrorHandler } from '@/app/api/core/utils/withErrorHandler'
-import { getFlattenProducts } from '@/app/api/quickbooks/product/product.controller'
+import { getProductsWithPrices } from '@/app/api/quickbooks/product/product.controller'
 
 export const maxDuration = 300 // 5 minutes
 
-export const GET = withErrorHandler(getFlattenProducts)
+export const GET = withErrorHandler(getProductsWithPrices)

src/app/api/quickbooks/product/product.controller.ts

@@ -5,10 +5,10 @@ import { ProductService } from '@/app/api/quickbooks/product/product.service'
 import { ProductMappingSchema } from '@/db/schema/qbProductSync'
 import { NextRequest, NextResponse } from 'next/server'
 
-export async function getFlattenProducts(req: NextRequest) {
+export async function getProductsWithPrices(req: NextRequest) {
   const user = await authenticate(req)
   const productService = new ProductService(user)
-  const products = await productService.getFlattenProductList()
+  const products = await productService.getProductsWithPrices()
   return NextResponse.json(products)
 }
 

src/app/api/quickbooks/product/product.service.ts

@@ -319,7 +319,7 @@ export class ProductService extends BaseService {
     return await intuitApi.createItem(qbItemPayload)
   }
 
-  async getFlattenProductList(): Promise<ProductFlattenArrayResponseType> {
+  async getProductsWithPrices(): Promise<ProductFlattenArrayResponseType> {
     const copilot = new CopilotAPI(this.user.token)
 
     const [products, pricesByProduct] = await Promise.all([
@@ -351,7 +351,7 @@ export class ProductService extends BaseService {
    * Walks every page of the workspace's /prices endpoint and groups by
    * productId. Replaces the prior bottleneck-throttled N+1 per-product fetch
    * with ceil(totalPrices / MAX_PRODUCT_LIST_LIMIT) sequential calls, which is
-   * dramatically faster for the single-page workload getFlattenProductList
+   * dramatically faster for the single-page workload getProductsWithPrices
    * actually serves. If product pagination is ever reintroduced, revisit:
    * caller would repeat this full walk per page with no cross-call cache.
    */