fix(OUT-3816): address regression review on the product mapping changes

- webhookProductUpdated now sends sparse:true so a name/description update no longer resets the QB item's UnitPrice to 0 (mapped items store null unitPrice now).
- handleProductMap calls unsetTransaction() before the initial-save early return, so the DB singleton isn't left on a closed tx.
- Drop the now-unused createdAt from the flatten DTO + getProductsForMapping.
- Remove stale numericPrice from the productKeyed test fixture; fix stale handleProductMap comment.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: SandipBajracharya

src/app/api/quickbooks/product/product.service.ts

@@ -206,7 +206,7 @@ export class ProductService extends BaseService {
 
   /**
    * On intial save, save all flatten products. If mapped, we include and if not, those are excluded
-   * On every save after that, we update the record on the basis of productId and priceId
+   * On every save after that, we update the record on the basis of productId
    */
   async handleProductMap(
     body: ProductMappingSchemaType,
@@ -234,6 +234,7 @@ export class ProductService extends BaseService {
               buildReturningFields(QBProductSync, returningFields),
             )
           : await query.returning()
+        this.unsetTransaction()
         return products
       }
 
@@ -338,7 +339,6 @@ export class ProductService extends BaseService {
       id: product.id,
       name: product.name,
       description: convert(product.description),
-      createdAt: product.createdAt,
     }))
 
     return { products: formatted }
@@ -447,10 +447,11 @@ export class ProductService extends BaseService {
           qbTokenInfo.incomeAccountRef,
         )
 
-        const fullUpdatePayload: QBItemFullUpdatePayloadType = {
+        const updatePayload: QBItemFullUpdatePayloadType = {
           Id: qbItemId,
           SyncToken: syncToken,
           Name: qbItemName,
+          sparse: true,
           ...(productDescription && { Description: productDescription }),
           ...(product.unitPrice
             ? { UnitPrice: parseFloat(product.unitPrice) / 100 }
@@ -462,7 +463,7 @@ export class ProductService extends BaseService {
           Type: QBItemType.SERVICE,
         }
 
-        const itemRes = await intuitApi.itemFullUpdate(fullUpdatePayload)
+        const itemRes = await intuitApi.itemFullUpdate(updatePayload)
 
         // update the product map in db
         const mapUpdatePayload = {

src/type/dto/api.dto.ts

@@ -4,7 +4,6 @@ export const ProductFlattenResponseSchema = z.object({
   id: z.string(),
   name: z.string(),
   description: z.string().nullish(),
-  createdAt: z.string().datetime(),
 })
 export type ProductFlattenResponseType = z.infer<
   typeof ProductFlattenResponseSchema

test/integration/quickbooks/productMap/productKeyed.test.ts

@@ -30,7 +30,6 @@ describe('POST /api/quickbooks/product/map — product-keyed upsert', () => {
             id: '777',
             name: 'Test Product',
             syncToken: '0',
-            numericPrice: 1499,
             description: '',
           },
         },