From 5f1d391d632e0fcf847e04e9ef319bf28fb92c5c Mon Sep 17 00:00:00 2001 From: Adrian-Stefan Mares <36161392+adriansmares@users.noreply.github.com> Date: Sun, 30 Nov 2025 17:07:10 +0100 Subject: [PATCH 1/3] Fix parameter order --- extension/extension.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extension/extension.cpp b/extension/extension.cpp index 4c85c6d..383110c 100644 --- a/extension/extension.cpp +++ b/extension/extension.cpp @@ -570,12 +570,12 @@ class UploadThread: public IThread { StderrInhibitor stdrrInhibitor; - if (!WriteSymbolFile(debugFile, debugFile, debugFile, "Linux", debug_dirs, options, outputStream)) { + if (!WriteSymbolFile(debugFile, debugFile, "Linux", debugFile, debug_dirs, options, outputStream)) { outputStream.str(""); outputStream.clear(); // Try again without debug dirs. - if (!WriteSymbolFile(debugFile, debugFile, debugFile, "Linux", {}, options, outputStream)) { + if (!WriteSymbolFile(debugFile, debugFile, "Linux", debugFile, {}, options, outputStream)) { if (log) fprintf(log, "Failed to process symbol file\n"); if (log) fflush(log); return false; From 8e56bdd77e171612b2041324f89a169930fadf8b Mon Sep 17 00:00:00 2001 From: Adrian-Stefan Mares <36161392+adriansmares@users.noreply.github.com> Date: Sun, 30 Nov 2025 17:20:11 +0100 Subject: [PATCH 2/3] Do not preserve address offset --- extension/extension.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension/extension.cpp b/extension/extension.cpp index 383110c..9a568a7 100644 --- a/extension/extension.cpp +++ b/extension/extension.cpp @@ -565,7 +565,7 @@ class UploadThread: public IThread }; std::ostringstream outputStream; - google_breakpad::DumpOptions options(ALL_SYMBOL_DATA, true, true, true); + google_breakpad::DumpOptions options(ALL_SYMBOL_DATA, true, true, false); { StderrInhibitor stdrrInhibitor; From 78d921c13efc0f976160cc20dd0e10c6f1621a33 Mon Sep 17 00:00:00 2001 From: Adrian-Stefan Mares <36161392+adriansmares@users.noreply.github.com> Date: Sun, 30 Nov 2025 17:29:34 +0100 Subject: [PATCH 3/3] Do not pass explicit symbol ID --- extension/extension.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extension/extension.cpp b/extension/extension.cpp index 9a568a7..2c75c96 100644 --- a/extension/extension.cpp +++ b/extension/extension.cpp @@ -570,12 +570,12 @@ class UploadThread: public IThread { StderrInhibitor stdrrInhibitor; - if (!WriteSymbolFile(debugFile, debugFile, "Linux", debugFile, debug_dirs, options, outputStream)) { + if (!WriteSymbolFile(debugFile, debugFile, "Linux", "", debug_dirs, options, outputStream)) { outputStream.str(""); outputStream.clear(); // Try again without debug dirs. - if (!WriteSymbolFile(debugFile, debugFile, "Linux", debugFile, {}, options, outputStream)) { + if (!WriteSymbolFile(debugFile, debugFile, "Linux", "", {}, options, outputStream)) { if (log) fprintf(log, "Failed to process symbol file\n"); if (log) fflush(log); return false;