Skip to content

Use modern xOBSE features to improve the mod hooking #2

Description

@ashemedai

Is your feature request related to a problem? Please describe.
The current mod uses a 1-second SetTimer repeatedly to install the hook. This is a potential race condition due to the fickleness of the Win32 message pump timing. It also is heavy on the polling.

Describe the solution you'd like
Install a hook from kMessage_GameInitialized.
This was added in xOBSE 22.10 (August 2024) and explicitly reads (obse/obse/PluginAPI.h#L232):

kMessage_GameInitialized // sent to plugins when the game is fully initialized (shows main menu)

Additional context
It does impose a hard requirement on xOBSE ≥ 22.10, however that version has been released since August, 2024. People have had two years to keep their script extender up-to-date.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions