Context
Smoke-testing zuraffa v6 (goal: build a ZikZak-class app at apps/zikzak_demo with ONLY zfa commands). The vertical slice passes (analyze 0 errors with #293), so I generated the grocery cluster: 8 entities (zfa entity create), then zfa make <Entity> --preset=crud --with=vpc,state,di,test,mock for each. zfa make and zfa build succeed, but flutter analyze on the cluster = 26 errors in two distinct classes.
Repro
zfa setup zikzak_demo --flutter --platforms=ios,macos,android
zfa entity create -n StorePrice --field depotId:String ... # NOTE: no `id` field
zfa entity create -n GroceryPriceResult --field storeName:String ... # NOTE: no `id` field
zfa entity create -n GroceryItem --field id:String --field canonicalName:String ... # HAS id
zfa make StorePrice --preset=crud --with=vpc,state,di,test,mock
zfa make GroceryItem --preset=crud --with=vpc,state,di,test,mock
zfa build
flutter analyze
Gap 1: generated code hardcodes EntityFields.id — breaks entities without an id field
Entities in the reference app that legitimately have no id field (e.g. StorePrice uses depotId, GroceryPriceResult uses storeName, GroceryPriceComparison uses itemName) produce broken generated code:
error • The getter 'id' isn't defined for the type 'StorePriceFields' (undefined_getter)
- test/domain/usecases/store_price/toggle_store_price_usecase_test.dart (3x)
- test/domain/usecases/store_price/get_store_price_usecase_test.dart (2x)
- lib/src/presentation/pages/store_price/store_price_presenter.dart (1x)
- same pattern for GroceryPriceResult (6x), GroceryPriceComparison (6x)
The generated presenter/tests reference StorePriceFields.id / GroceryPriceResultFields.id as the toggle/get field. For entities without id, the Fields class has no id member (only depotId etc.). The generators must resolve the entity's actual id field (first field, or a field named id/*Id) instead of hardcoding id.
Gap 2: mock datasource generates an empty class — methods default [] in mock plugin
The generated mock datasource implements the interface but has zero method bodies:
class GroceryItemMockDataSource with Loggable, FailureHandler implements GroceryItemDataSource {
GroceryItemMockDataSource([Duration? delay]) : _delay = delay ?? const Duration(milliseconds: 100);
final Duration _delay;
// NO get/update/toggle methods
}error • Missing concrete implementations of 'GroceryItemDataSource.get', 'GroceryItemDataSource.toggle', and 'GroceryItemDataSource.update'. (non_abstract_class_inherits_abstract_member)
- 8 mock datasources affected (all grocery entities)
Root cause: lib/src/plugins/mock/mock_plugin.dart:103 defaults methods to []:
methods: context.data['methods']?.cast<String>().toList() ?? [],
while the DI/usecase/test plugins were fixed (#287/#289) to default to ['get', 'update', 'toggle']. The mock datasource builder (mock_datasource_builder.dart:355) loops for (final method in config.methods) — with an empty list it emits no methods, producing a class that fails implements. When --methods=get,getList is passed explicitly, the mock datasource generates correctly (per earlier tests).
Suggested fix
- Gap 1: entity-aware id-field resolution — use the entity's actual id field (a field literally named
id, or the first field ending in Id, or --id-field) in presenter/toggle/get generators instead of hardcoded EntityFields.id.
- Gap 2: mock plugin default methods to
['get', 'update', 'toggle'] (same as the other plugins) so --preset=crud produces full mock datasources.
Impact
Blocks the grocery cluster (and every entity without a literal id field, plus every --with=mock generation without explicit --methods). The reference ZikZak app has multiple entities without id fields (StorePrice, GroceryPriceResult, GroceryPriceComparison, Barcode, ListingOffer, TelemetryEvent, ...), so full screen parity cannot be reached until Gap 1 is fixed.
Context
Smoke-testing zuraffa v6 (goal: build a ZikZak-class app at
apps/zikzak_demowith ONLY zfa commands). The vertical slice passes (analyze 0 errors with #293), so I generated the grocery cluster: 8 entities (zfa entity create), thenzfa make <Entity> --preset=crud --with=vpc,state,di,test,mockfor each.zfa makeandzfa buildsucceed, butflutter analyzeon the cluster = 26 errors in two distinct classes.Repro
Gap 1: generated code hardcodes
EntityFields.id— breaks entities without anidfieldEntities in the reference app that legitimately have no
idfield (e.g.StorePriceusesdepotId,GroceryPriceResultusesstoreName,GroceryPriceComparisonusesitemName) produce broken generated code:The generated presenter/tests reference
StorePriceFields.id/GroceryPriceResultFields.idas the toggle/get field. For entities withoutid, the Fields class has noidmember (onlydepotIdetc.). The generators must resolve the entity's actual id field (first field, or a field namedid/*Id) instead of hardcodingid.Gap 2: mock datasource generates an empty class — methods default
[]in mock pluginThe generated mock datasource implements the interface but has zero method bodies:
Root cause:
lib/src/plugins/mock/mock_plugin.dart:103defaultsmethodsto[]:while the DI/usecase/test plugins were fixed (#287/#289) to default to
['get', 'update', 'toggle']. The mock datasource builder (mock_datasource_builder.dart:355) loopsfor (final method in config.methods)— with an empty list it emits no methods, producing a class that failsimplements. When--methods=get,getListis passed explicitly, the mock datasource generates correctly (per earlier tests).Suggested fix
id, or the first field ending inId, or--id-field) in presenter/toggle/get generators instead of hardcodedEntityFields.id.['get', 'update', 'toggle'](same as the other plugins) so--preset=crudproduces full mock datasources.Impact
Blocks the grocery cluster (and every entity without a literal
idfield, plus every--with=mockgeneration without explicit--methods). The reference ZikZak app has multiple entities withoutidfields (StorePrice, GroceryPriceResult, GroceryPriceComparison, Barcode, ListingOffer, TelemetryEvent, ...), so full screen parity cannot be reached until Gap 1 is fixed.