refactor: Clean up imports in Company and Xbrl classes; update tests for Facts model

Author: areed1192

edgar/company.py

@@ -5,6 +5,11 @@
 from enum import Enum
 from typing import TYPE_CHECKING, Union
 
+from edgar.filings import Filings
+from edgar.models import CompanyInfo, Facts, Filing
+from edgar.submissions import Submissions
+from edgar.xbrl import Xbrl
+
 if TYPE_CHECKING:
     from edgar.session import EdgarSession
     from edgar.tickers import Tickers
@@ -120,8 +125,6 @@ def filings(
             >>> company.filings(form="10-K")
         """
 
-        from edgar.filings import Filings
-
         filings_service = Filings(session=self._session)
 
         if form is not None:
@@ -152,8 +155,6 @@ def submissions(self) -> dict | None:
             >>> company.submissions()
         """
 
-        from edgar.submissions import Submissions
-
         submissions_service = Submissions(session=self._session)
         return submissions_service.get_submissions(cik=self.cik_unpadded)
 
@@ -171,8 +172,6 @@ def xbrl_facts(self) -> dict | None:
             >>> company.xbrl_facts()
         """
 
-        from edgar.xbrl import Xbrl
-
         xbrl_service = Xbrl(session=self._session)
         return xbrl_service.company_facts(cik=self.cik_unpadded)
 
@@ -219,8 +218,6 @@ def get_filings(
             '10-K'
         """
 
-        from edgar.models import Filing
-
         raw_filings = self.filings(
             form=form, start=start, number_of_filings=number_of_filings
         )
@@ -245,8 +242,6 @@ def get_info(self) -> object:
             'Apple Inc.'
         """
 
-        from edgar.models import CompanyInfo
-
         raw = self.submissions()
         if raw is None:
             return None
@@ -270,8 +265,6 @@ def get_facts(self) -> object:
             >>> facts.get("us-gaap", "Revenue")
         """
 
-        from edgar.models import Facts
-
         raw = self.xbrl_facts()
         if raw is None:
             return None

edgar/xbrl.py

@@ -4,6 +4,7 @@
 
 from enum import Enum
 from typing import Union
+from edgar.models import Facts
 from edgar.session import EdgarSession
 
 
@@ -166,8 +167,6 @@ def get_facts(self, cik: str) -> object:
             >>> facts.get('us-gaap', 'Revenue')
         """
 
-        from edgar.models import Facts
-
         raw = self.company_facts(cik=cik)
         if raw is None:
             return None

tests/test_xbrl_facts.py

@@ -338,7 +338,7 @@ def test_units(self):
     def test_units_missing(self):
         """Verify units() returns empty list for missing concept."""
         facts = Facts(raw=SAMPLE_COMPANY_FACTS)
-        assert facts.units("us-gaap", "Nonexistent") == []
+        assert not facts.units("us-gaap", "Nonexistent")
 
     def test_raw_attribute(self):
         """Verify the raw dict is accessible."""
@@ -358,15 +358,15 @@ def test_empty_facts(self):
         facts = Facts(raw=SAMPLE_EMPTY_FACTS)
         assert facts.cik == 999999
         assert facts.entity_name == "Empty Corp"
-        assert facts.taxonomies == []
+        assert not facts.taxonomies
         assert facts.concepts() == []
 
     def test_defaults_for_missing_keys(self):
         """Verify graceful defaults for fully empty raw dict."""
         facts = Facts(raw={})
         assert facts.cik == 0
         assert facts.entity_name == ""
-        assert facts.taxonomies == []
+        assert not facts.taxonomies
 
     def test_frozen(self):
         """Verify the dataclass is immutable."""