Replies: 3 comments 1 reply
|
hi @JaredCE I have seen the PR passing by and it grew but then again, your contribution brings support for OpenAPI 3.1, next to the existing OpenAPI 3.0. So thanks already for taking the time to create this PR. The latest test run showed that something is off with certain types ( |
1 reply
|
Cheers Thim
A general review of the code would be useful too as I'm sure I've done
things that might make you scratch your head. Very happy to fix/change
anything, but would love some guidance
…On Sat, 4 Oct 2025, 12:35 Thim, ***@***.***> wrote:
hi @JaredCE <https://github.com/JaredCE>
I have seen the PR passing by and it grew but then again, your
contribution brings support for OpenAPI 3.1, next to the existing OpenAPI
3.0. So thanks already for taking the time to create this PR.
The latest test run showed that something is off with certain types (Type
'undefined' is not assignable to type '{}'.)
I'll try to make some time for this in the course of next week, to try to
figure out what is wrong with the type handling.
—
Reply to this email directly, view it on GitHub
<#709 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF4CYCJJY6VESE5X3GBYD33V6WITAVCNFSM6AAAAACII2NRAOVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTINJZGA4DQNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
0 replies
|
@thim81 I've just updated to fix the failing test. If you could take a look that'd be amazing |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hey there
So I opened this pull request: #708
It's to try and update the comaptibility with OpenAPI 3.1. I noticed that when
$schemawas included in a schema, if it was a draft-04 schema, it wouldn't validate the schema. This PR has become a lot bigger than I thought it would, and I'm not 100% on the quality of it.I have one failing suite that I'd love to get some help on. And would love any feedback about this, especially if it helps get it into the package.
We use portman, and would love to have all our documentation updated to OpenAPI 3.1, and updating this would help us get over the line.
All reactions