Skip to content

Make PageReader AutoCloseable #3767

Description

@abstractdog

PageReader implementations can own resources — ColumnChunkPageReader owns decompression / decryption buffers — but the interface has no standard teardown method. Today ColumnChunkPageReadStore.close() calls a package-private releaseBuffers() on the concrete class. Alternative PageReader implementations have no idiomatic way to declare that they own resources.

Have PageReader extend AutoCloseable with a default no-op close(). Rename ColumnChunkPageReader.releaseBuffers() to close().

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions