HBASE-30355 addendum: clean up MiniKdc dir on genuine (non-bind) setup failure too

Move the deleteDirectory(dir) call ahead of the isBindException check in
setupMiniKdc's catch block so the partially-initialized kdc dir is cleaned
up before rethrowing a non-bind failure, not just on a retried bind
conflict. Per review comment from virajjasani on PR #8604.

Author: mnpoonia

hbase-http/src/test/java/org/apache/hadoop/hbase/http/log/TestLogLevel.java

@@ -159,10 +159,10 @@ static private MiniKdc setupMiniKdc() throws Exception {
         // KrbException whose shape varies by version (see isBindException), so we recognise the
         // port conflict via that predicate rather than a type. We also avoid importing kerby types
         // here (see HBASE-29117).
+        FileUtils.deleteDirectory(dir); // clean directory regardless of failure type
         if (!isBindException(e)) {
           throw e; // not a port conflict, do not mask the real failure behind a retry
         }
-        FileUtils.deleteDirectory(dir); // clean directory
         numTries++;
         if (numTries == 3) {
           log.error("Failed setting up MiniKDC. Tried " + numTries + " times.");

hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java

@@ -3737,10 +3737,10 @@ public MiniKdc setupMiniKdc(File keytabFile) throws Exception {
         // KrbException whose shape varies by version (see isBindException), so we recognise the
         // port conflict via that predicate rather than a type. We also avoid importing kerby types
         // here (see HBASE-29117).
+        FileUtils.deleteDirectory(dir); // clean directory regardless of failure type
         if (!isBindException(e)) {
           throw e; // not a port conflict, do not mask the real failure behind a retry
         }
-        FileUtils.deleteDirectory(dir); // clean directory
         numTries++;
         if (numTries == 3) {
           LOG.error("Failed setting up MiniKDC. Tried " + numTries + " times.");