Skip to content

CI: two footguns — esbuild allowBuilds contradiction + PR build coupled to 7 downstream repos #20

Description

@CameronBrooks11

Two genuine CI footguns

  1. esbuild build-gate contradiction (S, High): package.json correctly sets pnpm.onlyBuiltDependencies:["esbuild"], but pnpm-workspace.yaml has allowBuilds:{esbuild:false} — an unrecognized pnpm key stating the opposite intent. This is exactly the esbuild-breakage footgun the org has hit before. Fix: net deletion, consolidate into pnpm-workspace.yaml.
  2. PR CI hard-coupled to 7 downstream repos (M, High): every PR build clones all 7 repos + fetches each one's latest-release metrics.json unauthenticated, and exit(1) on any miss — so a docs-only PR can red-fail for reasons entirely outside this repo (missing asset, rate limits). Fix: pass GITHUB_TOKEN to the build and/or move the metrics aggregation to a non-blocking lane.

Smaller (minimal-first)

  • Orphan .markdownlint-test.json (valid config wired to nothing) → delete or rename + wire.
  • Pin pnpm via packageManager; align engines.node (20) with CI (24). pnpm: latest is non-reproducible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions