Skip to content

Unused variable fetch in force commit handlerΒ #98

Description

@Vachhani-Tapan

πŸ› Bug Description

Line 1153 of bot.py fetches file_ids_for_force from user_data but does NOT assign it to any variable β€” the result is immediately discarded.

πŸ” Steps to Reproduce

  1. Trigger a force commit flow.
  2. Observe that file_ids_for_force is fetched but never used to filter staged_rows.

βœ… Expected Behavior

The file_ids_for_force should be used to filter which files are included in the force commit.

❌ Actual Behavior

The force commit logic may include files that were not part of the original conflict set, since file_ids_for_force is never used.

🌍 Environment

Field Value
OS Any
VS Code version Any
GitPhone extension version Any
Python version 3.11+

πŸ“‹ Additional Context

File: backend/bot.py:1152-1153
Fix: Assign and use the fetched value to filter staged rows.


Metadata

Metadata

Assignees

Labels

bugSomething isn't workingneeds-triageAwaiting admin review

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions