Clarify documentation section 001

[anicolao]

Quoted documentation:

The survivor estimate reflects the opposite weapons assumption, effectively granting your opponent the advantage.

This isn't right, the My WS-1 means give +1 weapons to the other side, not giving the opponent the advantage; in the example shown, the current player is neither side. It's a bit confusing because WS-1 sounds like my weapons level goes down, but it is actually +1 for me, and at the same time who "me" is is not clear if I am looking at two other players with the combat calculator. Let's do our best to clarify the documentation, and separately I'll file an issue to make it read My WS+1 which may help with part of the confusion.

[anicolao]

I am the automation

The conductor has picked up this task and is working on main.

[anicolao]

I am the conductor, and I am responding to the original issue on branch issue-59.

Please clarify the documentation regarding the My WS-1 combat calculation handicap.

The current documentation in tests/playwright/001-battle-hud/DOCS.md and the metadata in tests/playwright/001-battle-hud/001-battle-hud.spec.ts is confusing and partially incorrect. Specifically:

• It says My WS-1 grants the opponent the advantage, but it actually credits "your" side (the modeled side) with +1 weapons.
• It doesn't clearly explain who "Me/My" is when the user is looking at a battle between two other players.

Tasks:

1. Update tests/playwright/001-battle-hud/DOCS.md:
   • Around line 102, clarify that My WS-1 credits your side with an extra weapons level (+1), granting you the advantage.
   • Around line 112, update the "What to expect" to say it grants your side the weapons advantage.
   • Mention that although the label shows -1, it represents a +1 weapons advantage for your side.
2. Update tests/playwright/001-battle-hud/001-battle-hud.spec.ts:
   • Update the documentation block in the apply-my-ws-minus-one step (lines 402-415) to match the clarified text in DOCS.md.

Use npm run commit -- 59 "clarify documentation for My WS-1 handicap" for your commits.

[anicolao]

I am the automation

The conductor has picked up this task and is working on issue-59.

[anicolao]

I am the conductor, and I am responding to comment 4343862169 on branch issue-59.

Please clarify the documentation regarding the My WS-1 combat calculation handicap in the battle hud tests.

Tasks:

1. Update tests/playwright/001-battle-hud/DOCS.md:
   • At line 100, change "Model the opposite weapons advantage" to "Model a weapons advantage".
   • At line 102, clarify that "My WS-1" credits your side (the side NPA is modeling) with an extra weapons level (+1), granting you the advantage. Explicitly mention that although the label shows -1, it represents a +1 weapons advantage for your side.
   • At line 112, update the "What to expect" to say it grants your side the weapons advantage instead of "granting your opponent the advantage".
2. Update tests/playwright/001-battle-hud/001-battle-hud.spec.ts:
   • Update the documentation block in the apply-my-ws-minus-one step (around lines 402-415) to match the clarified text in DOCS.md.

Use npm run commit -- 59 "clarify documentation for My WS-1 handicap" for your commits.

[anicolao]

I am the automation

The coder has picked up this task and is working on issue-59.