From 443b0daa835b53746071bfc32281994fab535cd1 Mon Sep 17 00:00:00 2001
From: ysouissi <yassine.souissi@orange.com>
Date: Fri, 6 Feb 2026 00:35:11 +0100
Subject: [PATCH] fix(native-federation): fix i18n translation for lazy chunks
 and Windows paths

## Problem
Two issues with `translateFederationArtefacts`:
1. **Windows paths with spaces** break the `localize-translate` command
2. **Lazy-loaded chunks** containing `$localize` markers are not translated
   (only federation artifacts in `shared`/`exposes` were processed)

## Solution
- Quote all paths in the command for Windows compatibility
- Use `*.js` pattern to translate ALL JS files, including lazy chunks

Fixes #1055
---
 libs/native-federation/src/utils/i18n.ts | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/libs/native-federation/src/utils/i18n.ts b/libs/native-federation/src/utils/i18n.ts
index 12fe13af..763dd085 100644
--- a/libs/native-federation/src/utils/i18n.ts
+++ b/libs/native-federation/src/utils/i18n.ts
@@ -78,14 +78,9 @@ export async function translateFederationArtefacts(
 
   const translationOutPath = path.join(outputPath, 'browser', '{{LOCALE}}');
 
-  const federationFiles = [
-    ...federationResult.shared.map((s) => s.outFileName),
-    ...federationResult.exposes.map((e) => e.outFileName),
-  ];
-
-  // Here, we use a glob with an exhaustive list i/o `"*.js"`
-  // to improve performance
-  const sourcePattern = '{' + federationFiles.join(',') + '}';
+  // Use *.js to translate ALL JS files, including lazy-loaded chunks
+  // that may contain $localize markers from exposed modules
+  const sourcePattern = '*.js';
 
   const sourceLocalePath = path.join(outputPath, 'browser', sourceLocale);
 
@@ -93,7 +88,8 @@ export async function translateFederationArtefacts(
     'node_modules/.bin/localize-translate',
   );
 
-  const cmd = `${localizeTranslate} -r ${sourceLocalePath} -s "${sourcePattern}" -t ${translationFiles} -o ${translationOutPath} --target-locales ${targetLocales} -l ${sourceLocale}`;
+  // Quote paths to handle spaces (Windows compatibility)
+  const cmd = `"${localizeTranslate}" -r "${sourceLocalePath}" -s "${sourcePattern}" -t ${translationFiles} -o "${translationOutPath}" --target-locales ${targetLocales} -l ${sourceLocale}`;
 
   ensureDistFolders(locales, outputPath);
   copyRemoteEntry(locales, outputPath, sourceLocalePath);