fix(native-federation): Fix sharing issues

Author: Aukevanoost

libs/native-federation-core/src/lib/config/share-utils.ts

@@ -127,11 +127,12 @@ function _findSecondaries(
         .replace(/\\/g, '/')
         .replace(/^.*node_modules[/]/, '');
 
-      for (const e in excludes) {
-        if (e === secondaryLibName) continue;
-        if (e.endsWith('*') && secondaryLibName.startsWith(e.slice(0, -1)))
-          continue;
-      }
+      let inCustomSkipList = excludes.some(
+        (e) =>
+          e === secondaryLibName ||
+          (e.endsWith('*') && secondaryLibName.startsWith(e.slice(0, -1))),
+      );
+      if (inCustomSkipList) continue;
 
       if (isInSkipList(secondaryLibName, preparedSkipList)) {
         continue;
@@ -246,10 +247,12 @@ function readConfiguredSecondaries(
   for (const key of keys) {
     const secondaryName = path.join(parent, key).replace(/\\/g, '/');
 
-    for (const e in exclude) {
-      if (e === secondaryName) continue;
-      if (e.endsWith('*') && secondaryName.startsWith(e.slice(0, -1))) continue;
-    }
+    let inCustomSkipList = exclude.some(
+      (e) =>
+        e === secondaryName ||
+        (e.endsWith('*') && secondaryName.startsWith(e.slice(0, -1))),
+    );
+    if (inCustomSkipList) continue;
 
     if (isInSkipList(secondaryName, preparedSkipList)) {
       continue;

libs/native-federation-core/src/lib/core/build-for-federation.ts

@@ -179,6 +179,12 @@ async function bundlePerPackage(
     groupedByPackage[packageName][key] = shared;
   }
 
+  logger.info('Preparing shared npm packages for the platform ' + platform);
+  logger.notice('This only needs to be done once, as results are cached');
+  logger.notice(
+    "Skip packages you don't want to share in your federation config",
+  );
+
   const bundlePromises = Object.entries(groupedByPackage).map(
     async ([packageName, sharedGroup]) => {
       return bundleShared(

libs/native-federation-core/src/lib/core/bundle-shared.ts

@@ -93,14 +93,6 @@ export async function bundleShared(
     (ep) => !fs.existsSync(path.join(cacheOptions.pathToCache, ep.outName)),
   );
 
-  if (entryPoints.length > 0) {
-    logger.info('Preparing shared npm packages for the platform ' + platform);
-    logger.notice('This only needs to be done once, as results are cached');
-    logger.notice(
-      "Skip packages you don't want to share in your federation config",
-    );
-  }
-
   // If we build for the browser and don't remote unused deps from the shared config,
   // we need to exclude typical node libs to avoid compilation issues
   const useDefaultExternalList =

libs/native-federation-core/src/lib/utils/bundle-caching.ts

@@ -96,12 +96,9 @@ export const cacheEntry = (pathToCache: string, fileName: string) => ({
       logger.debug(`Creating cache folder '${pathToCache}' for '${fileName}'.`);
       return;
     }
-    if (!fs.existsSync(metadataFile)) {
-      logger.debug(
-        `Could not purge cached bundle, metadata file '${metadataFile}' does not exist.`,
-      );
-      return;
-    }
+    if (!fs.existsSync(metadataFile)) return;
+
+    logger.debug(`Purging cached bundle '${metadataFile}'.`);
 
     const cachedResult: {
       checksum: string;