Skip to content

Commit 89cfec0

Browse files
committed
fix(native-federation): Bug where wrong variable was used as export
1 parent 19b831e commit 89cfec0

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

libs/native-federation-core/src/lib/config/share-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const DEFAULT_SECONDARIES_SKIP_LIST = [
3030
];
3131

3232
type IncludeSecondariesOptions =
33-
| { skip: string | string[]; resolveGlob?: boolean }
33+
| { skip: string | string[]; resolveGlob?: boolean; shareAll?: boolean }
3434
| boolean;
3535
type CustomSharedConfig = SharedConfig & {
3636
includeSecondaries?: IncludeSecondariesOptions;

libs/native-federation-core/src/lib/utils/package-info.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -270,16 +270,13 @@ export function _getPackageInfo(
270270
);
271271

272272
if (packageJsonExportsEntry) {
273-
secondaryEntryPoint = packageJsonExportsEntry;
273+
secondaryEntryPoint = mainPkgJson?.exports?.[packageJsonExportsEntry];
274274

275-
if (secondaryEntryPoint.endsWith('*')) {
275+
if (packageJsonExportsEntry.endsWith('*')) {
276276
const replacement = relSecondaryPath.substring(
277277
packageJsonExportsEntry.length - 1,
278278
);
279-
secondaryEntryPoint = replaceGlob(
280-
mainPkgJson?.exports?.[packageJsonExportsEntry],
281-
replacement,
282-
);
279+
secondaryEntryPoint = replaceGlob(secondaryEntryPoint, replacement);
283280
}
284281
}
285282

0 commit comments

Comments
 (0)