|
function isgreater(a, b) |
|
isless(b, a) || isequal(a, b) |
|
end |
Should be isgreater(a, b) = isless(b, a).
It's correct in the README though!
|
* `isgreater(a, b) = isless(b, a)` |
In practice I think the tests don't catch this because they're only looking at the implementations of findall and findlast for these on UniqueSortIndex, which doesn't actually depend on the implementation.
AcceleratedArrays.jl/src/predicates.jl
Lines 40 to 42 in a77ffde
Should be
isgreater(a, b) = isless(b, a).It's correct in the README though!
AcceleratedArrays.jl/README.md
Line 120 in a77ffde
In practice I think the tests don't catch this because they're only looking at the implementations of
findallandfindlastfor these onUniqueSortIndex, which doesn't actually depend on the implementation.