From af6a2567d7755c5b8024ccc93f99ff00360c39b7 Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 10:12:39 +0300 Subject: [PATCH 01/11] test-pull-request-review test-pull-request-review --- rocro.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 rocro.yml diff --git a/rocro.yml b/rocro.yml new file mode 100644 index 0000000..6a00413 --- /dev/null +++ b/rocro.yml @@ -0,0 +1,10 @@ +inspecode: + gofmt: + thresholds: + num-issues: 0 + options: [-s] + go-test: + thresholds: + num-issues: 0 + misspell: default + golint: default From 26c60a969df90b11284c11346639e6f64561648d Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 10:14:12 +0300 Subject: [PATCH 02/11] test test --- client_clone.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client_clone.go b/client_clone.go index 4f0d943..5fdfc95 100644 --- a/client_clone.go +++ b/client_clone.go @@ -8,7 +8,7 @@ package websocket import "crypto/tls" -func cloneTLSConfig(cfg *tls.Config) *tls.Config { +fnc cloneTLSConfig(cfg *tls.Config) *tls.Config { if cfg == nil { return &tls.Config{} } From 2605e26d7053e649346c5bbaa3dcf6edfaadc47f Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 10:41:09 +0300 Subject: [PATCH 03/11] bug fixing bug fixing --- client_clone.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client_clone.go b/client_clone.go index 5fdfc95..4f0d943 100644 --- a/client_clone.go +++ b/client_clone.go @@ -8,7 +8,7 @@ package websocket import "crypto/tls" -fnc cloneTLSConfig(cfg *tls.Config) *tls.Config { +func cloneTLSConfig(cfg *tls.Config) *tls.Config { if cfg == nil { return &tls.Config{} } From b3c4c04908ec56b03092acfbe18ba29bf76322de Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 10:55:00 +0300 Subject: [PATCH 04/11] bug fixing bug fixing --- client_clone.go | 16 ---------------- 1 file changed, 16 deletions(-) delete mode 100644 client_clone.go diff --git a/client_clone.go b/client_clone.go deleted file mode 100644 index 4f0d943..0000000 --- a/client_clone.go +++ /dev/null @@ -1,16 +0,0 @@ -// Copyright 2013 The Gorilla WebSocket Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. - -// +build go1.8 - -package websocket - -import "crypto/tls" - -func cloneTLSConfig(cfg *tls.Config) *tls.Config { - if cfg == nil { - return &tls.Config{} - } - return cfg.Clone() -} From c07329711d1c30260bd536bd64a745ebdfcb0570 Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 10:55:53 +0300 Subject: [PATCH 05/11] bug-fixing bug-fixing --- client_clone.go | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 client_clone.go diff --git a/client_clone.go b/client_clone.go new file mode 100644 index 0000000..abd023e --- /dev/null +++ b/client_clone.go @@ -0,0 +1,17 @@ +// Copyright 2013 The Gorilla WebSocket Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// +build go1.8 + +package websocket + +import "crypto/tls" + +func cloneTLSConfig(cfg *tls.Config) *tls.Config { + if cfg == nil { + return &tls.Config{} + } + return cfg.Clone() +} + From 56e51c7ba2eaa7c187fa6c46e630d1dcd3db1216 Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 11:05:00 +0300 Subject: [PATCH 06/11] bug fixing bug fixing --- client_clone.go | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/client_clone.go b/client_clone.go index abd023e..f2482c1 100644 --- a/client_clone.go +++ b/client_clone.go @@ -1,17 +1,5 @@ -// Copyright 2013 The Gorilla WebSocket Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. - -// +build go1.8 - -package websocket - -import "crypto/tls" - -func cloneTLSConfig(cfg *tls.Config) *tls.Config { - if cfg == nil { - return &tls.Config{} - } - return cfg.Clone() +package main +import "fmt" +func main() { + fmt.Println("hello world") } - From cee771d97e5d52409c0c80646c6abf232bf2db7c Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 11:10:37 +0300 Subject: [PATCH 07/11] bug fixing bug fixing --- client_clone.go | 20 ++++++++++++++++---- rocro.yml | 4 ++-- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/client_clone.go b/client_clone.go index f2482c1..abd023e 100644 --- a/client_clone.go +++ b/client_clone.go @@ -1,5 +1,17 @@ -package main -import "fmt" -func main() { - fmt.Println("hello world") +// Copyright 2013 The Gorilla WebSocket Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// +build go1.8 + +package websocket + +import "crypto/tls" + +func cloneTLSConfig(cfg *tls.Config) *tls.Config { + if cfg == nil { + return &tls.Config{} + } + return cfg.Clone() } + diff --git a/rocro.yml b/rocro.yml index 6a00413..ee3fba8 100644 --- a/rocro.yml +++ b/rocro.yml @@ -1,10 +1,10 @@ inspecode: gofmt: thresholds: - num-issues: 0 + num-issues: 5 options: [-s] go-test: thresholds: - num-issues: 0 + num-issues: 5 misspell: default golint: default From 3e090393b38e175588c2668b11eac1a5f2256dec Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 11:17:58 +0300 Subject: [PATCH 08/11] bug fixing bug fixing --- client_clone.go | 1 - 1 file changed, 1 deletion(-) diff --git a/client_clone.go b/client_clone.go index abd023e..4f0d943 100644 --- a/client_clone.go +++ b/client_clone.go @@ -14,4 +14,3 @@ func cloneTLSConfig(cfg *tls.Config) *tls.Config { } return cfg.Clone() } - From 3fd81ba6a077d6f6da2394d6e4813ba862d589d7 Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 11:24:22 +0300 Subject: [PATCH 09/11] bug fixing bug fixing --- client_clone.go | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/client_clone.go b/client_clone.go index 4f0d943..c048119 100644 --- a/client_clone.go +++ b/client_clone.go @@ -1,16 +1,7 @@ -// Copyright 2013 The Gorilla WebSocket Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. +package main -// +build go1.8 +import "fmt" -package websocket - -import "crypto/tls" - -func cloneTLSConfig(cfg *tls.Config) *tls.Config { - if cfg == nil { - return &tls.Config{} - } - return cfg.Clone() +func main() { + fmt.Println("hello world") } From da288fe752b36a24afbaa617f6eaf2db19ee81c5 Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 11:26:46 +0300 Subject: [PATCH 10/11] bug fixing bug fixing --- client_clone.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/client_clone.go b/client_clone.go index c048119..62f83d5 100644 --- a/client_clone.go +++ b/client_clone.go @@ -1,7 +1,9 @@ -package main +// Copyright 2013 The Gorilla WebSocket Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. -import "fmt" +// +build go1.8 +package f -func main() { - fmt.Println("hello world") +func cloneTLSConfig() { } From 4b459e3d3b5f933c2d5af49a616f9e7b2e4f2502 Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Fri, 12 Oct 2018 21:16:29 +0300 Subject: [PATCH 11/11] bug fixing bug fixing --- rocro.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rocro.yml b/rocro.yml index ee3fba8..7eaabbf 100644 --- a/rocro.yml +++ b/rocro.yml @@ -1,10 +1,10 @@ inspecode: gofmt: thresholds: - num-issues: 5 + num-issues: 1 options: [-s] go-test: thresholds: - num-issues: 5 + num-issues: 1 misspell: default golint: default