Skip to content

[Bug]: alma stays outdated because Smart Updater does not apply manifest updates #392

Description

@yshgsh1343

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

alma

Expected/Current Behaviour

alma is currently outdated in this bucket. The manifest still points to 0.0.841, while the latest upstream release is v0.0.863 with the Windows x64 asset alma-0.0.863-win-x64.exe.

I expected the bucket updater to update bucket/alma.json automatically when a newer upstream release is available, but the manifest remains unchanged.

While checking the updater, I found that .github/scripts/smart-updater.ps1 currently runs:

scoop.cmd checkver $app.Name --force

This appears to only check versions and does not apply autoupdate changes to the manifest. On my latest local Scoop installation, scoop checkver is also not exposed as a Scoop command anymore:

WARN scoop: 'checkver' isn't a scoop command.

However, the underlying Scoop checkver script still exists and works:

<scoop prefix scoop>\bin\checkver.ps1

For example, this works locally:

$checkverScript = Join-Path (scoop prefix scoop) "bin/checkver.ps1"
& $checkverScript alma -Dir bucket -Update

I also noticed a few related updater workflow issues: it still uses the old set-output style instead of $GITHUB_OUTPUT, it uses exit 100 to signal that updates were found, and it writes the tracker file to .github/data/app-tracker.json without ensuring that .github/data exists first. These can make the workflow fail or skip the commit step even when an update is detected.

I tested updating alma locally to 0.0.863 with the following URL and SHA256:

https://github.com/yetone/alma-releases/releases/download/v0.0.863/alma-0.0.863-win-x64.exe#/dl.7z
074b29737d6f8c510e03b9041c74c40fdbf56b9cefd58aa69436addb145ab4ee

Local install from the updated manifest succeeded:

Installing 'alma' (0.0.863) [64bit]
Checking hash of alma-0.0.863-win-x64.exe ... ok.
Extracting alma-0.0.863-win-x64.exe ... done.
Running installer script...done.
Creating shortcut for Alma (Alma.exe)
'alma' (0.0.863) was installed successfully!

Alma.exe exists after installation at:

D:\Scoop\apps\alma\current\Alma.exe

A minimal fix would be to update bucket/alma.json to 0.0.863, call Scoop's underlying checkver.ps1 with -Dir and -Update, write GitHub Actions outputs through $GITHUB_OUTPUT, use a has_updates output instead of exit 100, and create .github/data before writing .github/data/app-tracker.json.

I can open a PR with this minimal fix if this approach is acceptable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions