From be8d39c88b6e19ab7e58fd6db2239287fdabb91a Mon Sep 17 00:00:00 2001 From: Caleb Ethridge Date: Tue, 4 Aug 2026 10:18:18 -0400 Subject: [PATCH] arch: sc5xx: Revert CDU0 CLKO10/12/13/14 IS_ENABLED guards CONFIG_CDU0_CLKOxx are "int" Kconfig options carrying a clock-source select value (range 1..7). IS_ENABLED() only evaluates true when a symbol is defined to 1, so any output configured with a value other than 1 was silently skipped. This, for example, left the clocks for the eMMC on the sc598 unconfigured, preventing the mmc from working in U-boot. Restore the original "#ifdef" guards so the outputs are configured whenever the board provides a value. Fixes: 3285a564d2b ("arch: sc5xx: Add SC846 DDR init hooks") Signed-off-by: Caleb Ethridge --- arch/arm/mach-sc5xx/init/clkinit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-sc5xx/init/clkinit.c b/arch/arm/mach-sc5xx/init/clkinit.c index 7016c2d75843..dcf328190647 100644 --- a/arch/arm/mach-sc5xx/init/clkinit.c +++ b/arch/arm/mach-sc5xx/init/clkinit.c @@ -536,16 +536,16 @@ void cdu_init(void) CONFIGURE_CDU0(CONFIG_CDU0_CLKO7, REG_CDU0_CFG7, 7); CONFIGURE_CDU0(CONFIG_CDU0_CLKO8, REG_CDU0_CFG8, 8); CONFIGURE_CDU0(CONFIG_CDU0_CLKO9, REG_CDU0_CFG9, 9); -#if (IS_ENABLED(CONFIG_CDU0_CLKO10)) +#ifdef CONFIG_CDU0_CLKO10 CONFIGURE_CDU0(CONFIG_CDU0_CLKO10, REG_CDU0_CFG10, 10); #endif -#if (IS_ENABLED(CONFIG_CDU0_CLKO12)) +#ifdef CONFIG_CDU0_CLKO12 CONFIGURE_CDU0(CONFIG_CDU0_CLKO12, REG_CDU0_CFG12, 12); #endif -#if (IS_ENABLED(CONFIG_CDU0_CLKO13)) +#ifdef CONFIG_CDU0_CLKO13 CONFIGURE_CDU0(CONFIG_CDU0_CLKO13, REG_CDU0_CFG13, 13); #endif -#if (IS_ENABLED(CONFIG_CDU0_CLKO14)) +#ifdef CONFIG_CDU0_CLKO14 CONFIGURE_CDU0(CONFIG_CDU0_CLKO14, REG_CDU0_CFG14, 14); #endif }