Skip to content

Add more tests for LCP client fallback and error handling #29

Description

@amirHdev

The LCP HTTP client has basic coverage now, but there are still some fallback and error paths worth pinning down.

I’m looking for small, targeted tests here, not a rewrite.

Things worth covering:

  • GetLicense fallback behavior when one fetch path fails
  • revoke behavior for non-200 responses beyond the already-covered soft cases
  • malformed or unexpected response handling where it makes sense
  • any other easy-to-isolate branch in the client

Suggested files:

  • internal/lcp/license/license.go
  • internal/lcp/license/license_client_test.go

Acceptance criteria:

  • use httptest
  • keep tests readable
  • do not depend on external services
  • go test ./... passes

Notes:
Good fit if you want to work on something integration-flavored without needing real infra.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    goPull requests that update go codegood first issueGood for newcomershelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions