-
Notifications
You must be signed in to change notification settings - Fork 3
Expand tests for the LCP license HTTP client #17
Copy link
Copy link
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationgoPull requests that update go codePull requests that update go codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Activity
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationgoPull requests that update go codePull requests that update go codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Summary
Add more branch coverage around the LCP license HTTP client, especially the non-happy-path behavior for license fetch and revoke requests.
Why this matters
This package sits on an important integration seam, and better tests here would make refactors safer without requiring deep knowledge of the whole codebase.
Suggested files
internal/lcp/license/license.gointernal/lcp/license/license_client_test.goAcceptance criteria
GetLicensefallback path.RevokeLicenseerror path beyond the existing soft-404 case.httptestand do not depend on external services.go test ./...passes.Nice to have