Skip to content

Expand tests for the LCP license HTTP client #17

Description

@amirHdev

Summary

Add more branch coverage around the LCP license HTTP client, especially the non-happy-path behavior for license fetch and revoke requests.

Why this matters

This package sits on an important integration seam, and better tests here would make refactors safer without requiring deep knowledge of the whole codebase.

Suggested files

  • internal/lcp/license/license.go
  • internal/lcp/license/license_client_test.go

Acceptance criteria

  • Tests cover at least one failing GetLicense fallback path.
  • Tests cover at least one RevokeLicense error path beyond the existing soft-404 case.
  • Tests use httptest and do not depend on external services.
  • go test ./... passes.

Nice to have

  • Keep the test server setup easy to read for first-time contributors.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationgoPull requests that update go codegood first issueGood for newcomershelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions