From 7e75ac9c3003433b76f7a3b3576a03ca2f2eb5c9 Mon Sep 17 00:00:00 2001 From: Haoyang Ding Date: Wed, 17 Mar 2021 15:04:14 -0700 Subject: [PATCH] Haoyang Ding's codeReview /* * Haoyang Ding => Nabil: * * Your code style is great. I need to learn how you name variables and functions * It seems that you write a lot of code, the 'windows.location' things. Actually, I think a relative url will work. * But since I don't have your db url, I can't try it on my localhost. * And for the space issue, you want to change it to %20. There are several methods called escape(), encodeURI(), encodeURIComponent() * Maybe these functions would help. * * */ --- public/javascripts/genre.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/public/javascripts/genre.js b/public/javascripts/genre.js index 801456c..810b89a 100644 --- a/public/javascripts/genre.js +++ b/public/javascripts/genre.js @@ -1,3 +1,15 @@ +/* +* Haoyang Ding => Nabil: +* +* Your code style is great. I need to learn how you name variables and functions +* It seems that you write a lot of code, the 'windows.location' things. Actually I think a relative url will work. +* But since I don't have your db url, I can't try it on your project. +* And for the space issue, you want to change it to %20. There are several methods called escape(), encodeURI(), encodeURIComponent() +* Maybe these functions would help. +* +* */ + + let reviewsContainer = document.querySelector("#reviewsContainer"); let genreTitle = document.querySelector("#genreTitle"); let imageObject = {