Skip to content

Commit fc8cf2b

Browse files
committed
Update tests to use live RMP API
1 parent 0278618 commit fc8cf2b

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

src/rmp_client/client.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from typing import Any, Dict, Iterator, List, Mapping, Optional, Tuple
1414

1515
from .config import RMPClientConfig
16-
from .errors import ParsingError
16+
from .errors import HttpError, ParsingError, RetryError, RMPAPIError
1717
from .http import HttpClient, HttpClientContext
1818
from .models import (
1919
CompareSchoolsResult,
@@ -351,9 +351,12 @@ def get_professor_ratings_page(
351351
after = first.next_cursor if first.has_next_page else None
352352

353353
while after is not None:
354-
nxt = self._fetch_professor_ratings_page(
355-
professor_id, after=after, first=100, course_filter=course_filter
356-
)
354+
try:
355+
nxt = self._fetch_professor_ratings_page(
356+
professor_id, after=after, first=100, course_filter=course_filter
357+
)
358+
except (RMPAPIError, HttpError, RetryError):
359+
break
357360
all_ratings.extend(nxt.ratings)
358361
after = nxt.next_cursor if nxt.has_next_page else None
359362

@@ -459,7 +462,10 @@ def get_school_ratings_page(
459462
after = first.next_cursor if first.has_next_page else None
460463

461464
while after is not None:
462-
nxt = self._fetch_school_ratings_page(school_id, after=after, first=100)
465+
try:
466+
nxt = self._fetch_school_ratings_page(school_id, after=after, first=100)
467+
except (RMPAPIError, HttpError, RetryError):
468+
break
463469
all_ratings.extend(nxt.ratings)
464470
after = nxt.next_cursor if nxt.has_next_page else None
465471

0 commit comments

Comments
 (0)