Remove unecessary queries

Author: amaanjaved1

src/rmp_client/client.py

@@ -27,8 +27,6 @@
     SchoolSearchResult,
 )
 from .queries import (
-    GET_SCHOOL_QUERY,
-    GET_TEACHER_QUERY,
     RATINGS_LIST_QUERY,
     SCHOOL_RATINGS_LIST_QUERY,
     SCHOOL_SEARCH_RESULTS_QUERY,
@@ -285,20 +283,13 @@ def iter_professors_for_school(
     # ---- Professor details + ratings ---------------------------------------------
 
     def get_professor(self, professor_id: str) -> Professor:
-        """Fetch a single professor by legacy numeric ID (GetTeacherQuery)."""
-        node_id = _teacher_node_id(professor_id)
-        data = self.raw_query({
-            "operationName": "GetTeacherQuery",
-            "query": GET_TEACHER_QUERY,
-            "variables": {"id": node_id},
-        })
+        """Fetch a single professor by legacy numeric ID.
 
-        node = (data.get("data") or {}).get("node")
-        if not node:
-            raise ParsingError(
-                f"Teacher not found in GraphQL response for id={professor_id}"
-            )
-        return self._parse_professor_node(node)
+        Uses the ratings list query with a minimal page size to retrieve
+        full teacher details in a single request.
+        """
+        page = self._fetch_professor_ratings_page(professor_id, first=1)
+        return page.professor
 
     def get_professor_ratings_page(
         self,
@@ -399,20 +390,13 @@ def iter_professor_ratings(
     # ---- School details + ratings ------------------------------------------------
 
     def get_school(self, school_id: str) -> School:
-        """Fetch a single school by legacy numeric ID (GetSchoolQuery)."""
-        node_id = _school_node_id(school_id)
-        data = self.raw_query({
-            "operationName": "GetSchoolQuery",
-            "query": GET_SCHOOL_QUERY,
-            "variables": {"id": node_id},
-        })
+        """Fetch a single school by legacy numeric ID.
 
-        node = (data.get("data") or {}).get("node")
-        if not node:
-            raise ParsingError(
-                f"School not found in GraphQL response for id={school_id}"
-            )
-        return self._parse_school_node(node)
+        Uses the school ratings list query with a minimal page size to retrieve
+        full school details (including category summaries) in a single request.
+        """
+        page = self._fetch_school_ratings_page(school_id, first=1)
+        return page.school
 
     def get_compare_schools(
         self, school_id_1: str, school_id_2: str
@@ -596,13 +580,7 @@ def _fetch_school_ratings_page(
                 "GraphQL response missing data.node (school not found or invalid id)"
             )
 
-        school = self._parse_school_node({
-            "id": node.get("legacyId") or node.get("id") or school_id,
-            "name": node.get("name"),
-            "city": node.get("city"),
-            "state": node.get("state"),
-            "country": node.get("country"),
-        })
+        school = self._parse_school_node(node)
 
         ratings_conn = node.get("ratings") or {}
         edges = ratings_conn.get("edges") or []

src/rmp_client/queries.py

@@ -72,6 +72,20 @@
       city
       state
       country
+      numRatings
+      avgRatingRounded
+      summary {
+        campusCondition
+        campusLocation
+        careerOpportunities
+        clubAndEventActivities
+        foodQuality
+        internetSpeed
+        schoolReputation
+        schoolSafety
+        schoolSatisfaction
+        socialActivities
+      }
       ratings(first: $count, after: $cursor) {
         edges {
           cursor
@@ -165,56 +179,3 @@
 }
 """
 
-GET_TEACHER_QUERY = """
-query GetTeacherQuery($id: ID!) {
-  node(id: $id) {
-    ... on Teacher {
-      id
-      legacyId
-      firstName
-      lastName
-      department
-      avgRating
-      avgDifficulty
-      numRatings
-      wouldTakeAgainPercent
-      school {
-        id
-        legacyId
-        name
-        city
-        state
-      }
-    }
-  }
-}
-"""
-
-GET_SCHOOL_QUERY = """
-query GetSchoolQuery($id: ID!) {
-  node(id: $id) {
-    ... on School {
-      id
-      legacyId
-      name
-      city
-      state
-      country
-      numRatings
-      avgRatingRounded
-      summary {
-        campusCondition
-        campusLocation
-        careerOpportunities
-        clubAndEventActivities
-        foodQuality
-        internetSpeed
-        schoolReputation
-        schoolSafety
-        schoolSatisfaction
-        socialActivities
-      }
-    }
-  }
-}
-"""

tests/test_client.py

@@ -388,13 +388,12 @@ def test_multi_page(self, client: RMPClient) -> None:
 
 class TestRawQuery:
     def test_sends_query_and_gets_response(self, client: RMPClient) -> None:
-        from rmp_client.queries import GET_SCHOOL_QUERY
         import base64
 
         node_id = base64.b64encode(f"School-{SCHOOL_QUEENS}".encode()).decode()
         result = client.raw_query({
             "operationName": "GetSchoolQuery",
-            "query": GET_SCHOOL_QUERY,
+            "query": "query GetSchoolQuery($id: ID!) { node(id: $id) { ... on School { id legacyId name } } }",
             "variables": {"id": node_id},
         })
         assert "data" in result