From 91b3aec449e623d6c7faf52692d90c81fd1613b9 Mon Sep 17 00:00:00 2001 From: Felix Eckhofer Date: Fri, 21 Jul 2023 09:29:59 +0200 Subject: [PATCH 1/3] Fix hidden background-images for disabled inputs background would also overwrite background-image, hiding the icons when the inputs where disabled. --- src/general/inputs.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/general/inputs.scss b/src/general/inputs.scss index 87df7d3..51d16c6 100644 --- a/src/general/inputs.scss +++ b/src/general/inputs.scss @@ -30,7 +30,7 @@ select { &[disabled], &:disabled { - background: var(--secondary-lighter); + background-color: var(--secondary-lighter); color: var(--secondary-light); } From a640debcf24bbd20395fbd46b40abc3923cf38f8 Mon Sep 17 00:00:00 2001 From: Felix Eckhofer Date: Fri, 21 Jul 2023 09:31:23 +0200 Subject: [PATCH 2/3] Allow checked radio controls/checkboxes to be identified when disabled Without this, it is impossible to tell checked and unchecked controls apart when they are disabled. --- src/general/inputs.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/general/inputs.scss b/src/general/inputs.scss index 51d16c6..49149ae 100644 --- a/src/general/inputs.scss +++ b/src/general/inputs.scss @@ -194,6 +194,9 @@ input[type="checkbox"] { &:disabled { box-shadow: inset 0 0 0 0.185rem var(--secondary-lighter); background: var(--secondary-lighter); + &:checked { + background: var(--secondary-light); + } } } From 355227db18f9e5d40cfcaf0cbcdaf2719a13e959 Mon Sep 17 00:00:00 2001 From: Felix Eckhofer Date: Fri, 21 Jul 2023 09:32:41 +0200 Subject: [PATCH 3/3] Fix inconsistency for disabled select controls The missing :not(:disabled) meant that the background color did not match with other controls in disabled state. --- src/general/inputs.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/general/inputs.scss b/src/general/inputs.scss index 49149ae..0a7e9f7 100644 --- a/src/general/inputs.scss +++ b/src/general/inputs.scss @@ -201,7 +201,7 @@ input[type="checkbox"] { } // select -select:not([multiple]):not([disabled]) { +select:not([multiple]):not([disabled]):not(:disabled) { -webkit-appearance: none; appearance: none; background-image: url("data:image/svg+xml;utf8,");