Commit c048e52
feat: attention escalation — idle-aware presence, floating approval prompt, alert guidance, cross-device forward (goal 0023)
Closes the twice-observed missed-decision failure ('background-ish
pattern, not user attention pattern'):
- internal/adapters/idletime (ioreg HIDIdleTime shell-out, zero cgo,
no TCC gate — research-verified; the clipboard.go pattern): presence
is now idle-aware. SettingsService.isAway is the ONE decision point:
away = unfocused OR idle >= threshold (default 300s, Teams' own
away default; a Settings knob). Fixes the focused-but-absent
suppression bug (document.hasFocus() alone said 'present' for an
unattended Mac). Idletime errors fail toward notifying.
- Floating approval prompt (the incoming-call/askpass pattern,
ADR-0033's second-window mechanism reused): a small always-on-top
window appears over whatever app is focused when a decision parks
while away — Approve/Deny inline for MCP writes, Open-in-Mill for
guardrail parks (typed input, never blind approval). Deliberately
no HideOnFocusLost: a decision prompt never auto-dismisses (the
VS Code severity rule); Escape is the explicit dismiss.
- notify.Start now actually requests notification authorization
(never called before — found reading the pinned source); Settings
copy documents the macOS Alerts-style toggle (Duo's documented ask).
- Cross-device forward (default off): pending decisions optionally
POST {kind,id,description,createdAt} through the user's OWN
configured HTTPRequest via the same transport tail Decision
webhooks use (never a second HTTP client) — the only layer that
reaches an owner at another machine; §1.1-clean. httptest-covered.
- e2e: approval-prompt.spec.ts (hash-route standalone render +
approve-executes); mcpTestClient.ts extracted as the shared
real-MCP-client helper. Window-level behaviors manual-only.
Goal 0023 archived; SPEC §3.7 + ADR-0032 Update in-change. Full gates
green (go -race, lint both tag sets, 178 vitest, 153 e2e).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft1 parent d166c94 commit c048e52
28 files changed
Lines changed: 1466 additions & 94 deletions
File tree
- docs
- adr
- goals
- archive
- frontend
- bindings/github.com/alicoding/mill/internal/services
- guardrailsvc
- settingssvc
- e2e
- src
- app
- views
- internal
- adapters
- idletime
- notify
- domain/composition
- services/settingssvc
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2598 | 2598 | | |
2599 | 2599 | | |
2600 | 2600 | | |
| 2601 | + | |
| 2602 | + | |
| 2603 | + | |
| 2604 | + | |
| 2605 | + | |
| 2606 | + | |
| 2607 | + | |
| 2608 | + | |
| 2609 | + | |
| 2610 | + | |
| 2611 | + | |
| 2612 | + | |
| 2613 | + | |
| 2614 | + | |
| 2615 | + | |
| 2616 | + | |
| 2617 | + | |
| 2618 | + | |
| 2619 | + | |
| 2620 | + | |
| 2621 | + | |
| 2622 | + | |
| 2623 | + | |
2601 | 2624 | | |
2602 | 2625 | | |
2603 | 2626 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
44 | 47 | | |
45 | 48 | | |
46 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
28 | 34 | | |
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
32 | 38 | | |
33 | 39 | | |
34 | 40 | | |
35 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
36 | 44 | | |
37 | 45 | | |
38 | 46 | | |
| |||
58 | 66 | | |
59 | 67 | | |
60 | 68 | | |
61 | | - | |
| 69 | + | |
62 | 70 | | |
63 | 71 | | |
64 | 72 | | |
| |||
0 commit comments