You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: the Extensions list gets its industry-standard treatment -- grouped, noun-named, contained details, no escaping knobs
Five hands-on-review findings against Settings > Extensions:
- The toggle knob's own compositor layer could paint outside its row
after scrolling with a disclosure open; contain: paint on the row
scopes every descendant's paint (and gives it a containing block)
so this can never happen structurally.
- The list groups into Knowledge/Files/Drawing sections (registry
`group`, now shared by tray tools and tool-less nouns via the new
AtlasNounGroup type) instead of repeating the group word on every
row's own meta line.
- Row titles read as the noun ("Card", "Pencil") via a new nounName
field, separate from the command-verb label ("Add a card") that
still drives the palette/tray tooltips.
- The bare On/Off status text next to each switch is hidden (it was
always aria-hidden in Primer's own markup, so nothing is lost for
screen readers).
- The Annotate tray group's own collapsed trigger now derives its face
icon from the first enabled tool in the group instead of a hardcoded
paintbrush, so disabling that tool never leaves a stale glyph.
atlasNounRegistry.ts split along its own real seam (board-object
content registry vs. the tray-tool registry) to stay under the
500-line file limit, re-exported in full so no other importer moves.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
if(!box)thrownewError('extensions-row-meta has no bounding box')
134
+
// A single line of this small-text token is well under 24px tall;
135
+
// two wrapped lines would roughly double it.
136
+
expect(box.height).toBeLessThan(24)
137
+
})
138
+
139
+
test('The toggle knob stays contained within its own row, even scrolled with a disclosure open (regression: it painted over the sticky search bar)',async({ page })=>{
0 commit comments