Make Pool Length Editable in "Edit Swim Lengths" Dialog

[idealist1508]

Currently, pool length (25m/50m/25y/50y) is displayed as read-only text in "Edit Swim Lengths" dialog. If the pool length was set incorrectly during recording, there's no way to fix it afterward—even though all distance, speed, and pace metrics depend on this value.

Real-world use case:

I swim in a 50m pool with pace alerts on my Garmin. Alerts trigger at each turn, but with flip turns I don't notice them. As a workaround, I set pool length to 25m so alerts fire mid-pool. But then all metrics are wrong. I need to correct pool length retroactively.

[alex-hhh]

This makes sense, I will need some time to determine how to implement this - I don't think it would fit nicely in the swim lap editor, but I can create a separate dialog for this.

[idealist1508]

My idea was to replace the label with a combobox. Any changes to laps should disable this combobox, and changes to pool length will disable all operations on laps. I implemented this feature with AI, and it looks ok to me.
feature/edit-lap-length
Should I make a PR?

[alex-hhh]

The code in edit-lap-swim.rkt is unnecessarily complicated and fragile (I wrote it myself). I don't want to add additional features there, as I think there is a big risk of breaking existing functionality and there are no unit tests either for this code either.

I will make a separate dialog for editing the pool length, it seems to me less risky. I think I'll be done on the weekend (I'm busy with work during the week).

[idealist1508]

Thanks! There's no rush on this. I have a workaround in place for now. 😲

[alex-hhh]

I added a new "Edit Pool Length" dialog, available from the "Activity/Edit Swimming Pool Length..." menu. It is a bit more complex than your changes, as it allows setting the pool length both for meters and yards as well as custom pool lengths. Can you please give it a try before I merge this to master?

https://github.com/alex-hhh/ActivityLog2/tree/ah/gh105

Thanks, Alex.

[idealist1508]

Hi Alex,

I gave it a try, but unfortunately the new dialog does not appear on my system.

Instead, I get the following error after selecting Activity → Edit Swimming Pool Length...:

(ActivityLog2:4252): Gtk-WARNING **: 20:04:42.992: Negative content width -11 (allocation 1, extents 6x6) while allocating gadget (node button, owner GtkButton)
initialization for message%: contract violation
  expected: (or/c label-string? (is-a?/c bitmap%) 'app 'caution 'stop)
  given: #<sql-null>
  context...:
   .../private/mritem.rkt:112:2
   .../private/class-internal.rkt:3633:0: continue-make-object
   .../private/class-internal.rkt:3607:0: do-make-object/real-class
   .../dialogs/edit-pool-length.rkt:204:2
   .../private/class-internal.rkt:3633:0: continue-make-object
   .../private/class-internal.rkt:3607:0: do-make-object/real-class
   .../dialogs/edit-pool-length.rkt:406:0: interactive-edit-session-pool-length
   .../private/arrow-val-first.rkt:518:18
   .../dialogs/activity-edit.rkt:236:4: on-edit-pool-length
   .../private/mrmenu.rkt:250:14: command method in basic-selectable-menu-item%
   .../private/more-scheme.rkt:145:2: call-with-break-parameterization
   .../private/more-scheme.rkt:263:2: call-with-exception-handler
   .../common/queue.rkt:436:6
   .../common/queue.rkt:487:32
   .../common/queue.rkt:639:3

For reference, I'm using Racket v9.2.

Thanks,

[idealist1508]

After making the following change. The conversion from a 25 m pool to a 50 m pool worked well. Thanks

diff --git a/rkt/dialogs/edit-pool-length.rkt b/rkt/dialogs/edit-pool-length.rkt
index 590f924..007ae1d 100644
--- a/rkt/dialogs/edit-pool-length.rkt
+++ b/rkt/dialogs/edit-pool-length.rkt
@@ -173,15 +173,17 @@
         and SSL.swim_stroke_id is not null
       group by S.id"
      sid))
+  (define (sql-or value fallback)
+    (if (sql-null? value) fallback value))
   (values
-   (or headline "Unnamed Session")
-   (or start-time (current-seconds))
-   (or time-zone #f)
-   (or pool-length 50)
-   (or pool-length-unit 0)
-   duration
-   lengths
-   fastest-length))
+   (sql-or headline "Unnamed Session")
+   (sql-or start-time (current-seconds))
+   (sql-or time-zone #f)
+   (sql-or pool-length 50)
+   (sql-or pool-length-unit 0)
+   (sql-or duration 0)
+   (sql-or lengths 0)
+   (sql-or fastest-length 1)))
 
 (define (validate-non-negative-rational v)
   (define n (string->number v))
@@ -191,10 +193,12 @@
   (define meters
     (* pl (if (= plu 0) 1.0 0.9144)))
   (define distance (* length-count meters))
+  (define avg-speed (if (> duration 0) (/ distance duration) 0))
+  (define max-speed (if (> fastest-length 0) (/ meters fastest-length) 0))
   (values
    distance
-   (/ distance duration)
-   (/ meters fastest-length)))
+   avg-speed
+   max-speed))

[alex-hhh]

Thanks for diagnosing the issue, I applied your patch and pushed an update to this branch.