Use llama.cpp directory path as the download path#6
Open
KevinRSX wants to merge 1 commit into
Open
Conversation
akx
requested changes
Apr 29, 2025
akx
left a comment
akx
left a comment
Owner
There was a problem hiding this comment.
I don't think the llama.cpp path is the right default – it could well be e.g. /opt/llamacpp/bin, and not necessarily writable by a layperson.
Being able to set the models path via an option would be better – but let's default it to ./models anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The converter should be able to find the right model path. Just changing the download path is definitely still inflexible - if you want to support an external converter, I can add some more command line options here.