Topic
Refresh syncs do not trigger the execution of sync notifications, such as Successful Sync, Failed Sync
Relevant information
Platform Version
- Edition: community
- Version: Observed on 1.0.0, reproduced through 2.2
- Deployment: GKE, local abctl
Description
Triggering a Refresh Sync does not appear to execute any of the webhook notifications associated with sync events.
This is surprising because my impression from the documentation is that refresh syncs are considered to be syncs, and I'd expect to be able to notify on their success/failure (since they have similar effects - changes in the synced data).
The code in JobCreationAndStatusUpdateHelper.kt defines val SYNC_CONFIG_SET: Set<ConfigType> = setOf(ConfigType.SYNC, ConfigType.REFRESH), which seems in line with the documentation. The JobsHandler class though conditions sync notification execution on ConfigType.SYNC rather than SYNC_CONFIG_SET, meaning ConfigType.REFRESH do not emit notifications.
Steps to reproduce
- Have a connection that supports Refresh Syncs
- Configure and enable webhooks for Successful sync, Failed sync per https://docs.airbyte.com/platform/cloud/managing-airbyte-cloud/manage-airbyte-cloud-notifications#set-up-webhook-notifications
- Sync the connection - observe notifications trigger.
- Refresh the connections - no notifications trigger.
Internal Tracking: https://github.com/airbytehq/oncall/issues/13311
Topic
Refresh syncs do not trigger the execution of sync notifications, such as Successful Sync, Failed Sync
Relevant information
Platform Version
Description
Triggering a Refresh Sync does not appear to execute any of the webhook notifications associated with sync events.
This is surprising because my impression from the documentation is that refresh syncs are considered to be syncs, and I'd expect to be able to notify on their success/failure (since they have similar effects - changes in the synced data).
The code in
JobCreationAndStatusUpdateHelper.ktdefinesval SYNC_CONFIG_SET: Set<ConfigType> = setOf(ConfigType.SYNC, ConfigType.REFRESH), which seems in line with the documentation. TheJobsHandlerclass though conditions sync notification execution onConfigType.SYNCrather thanSYNC_CONFIG_SET, meaningConfigType.REFRESHdo not emit notifications.Steps to reproduce
Internal Tracking: https://github.com/airbytehq/oncall/issues/13311