From 92c7eea51c8d1de0d8234c750b708007afa972ea Mon Sep 17 00:00:00 2001 From: Nicola Spanti Date: Wed, 15 Jul 2026 11:11:51 +0200 Subject: [PATCH] forbid to call `get_record` and `record` with named parameters Like this, it really forbids it. So it is cleaner than a parameter made private by convention. --- geocube/client.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/geocube/client.py b/geocube/client.py index db0d766..8aa8ec6 100644 --- a/geocube/client.py +++ b/geocube/client.py @@ -196,14 +196,14 @@ def create_records(self, aoi_ids: List[str], names: List[str], """ return self._create_records(aoi_ids, names, tags, dates) - def get_record(self, _id: str) -> entities.Record: + def get_record(self, an_id: str, /) -> entities.Record: """ Deprecated: use record() instead """ - return self.record(_id) + return self.record(an_id) - def record(self, _id: str) -> entities.Record: + def record(self, an_id: str, /) -> entities.Record: """ Get a record by id """ - r = self.get_records([_id]) - assert len(r) > 0, utils.GeocubeError("get_record", grpc.StatusCode.NOT_FOUND.name, "record with id " + _id) + r = self.get_records([an_id]) + assert len(r) > 0, utils.GeocubeError("get_record", grpc.StatusCode.NOT_FOUND.name, "record with id " + an_id) return r[0] def get_records(self, ids: List[str]) -> List[entities.Record]: @@ -1031,4 +1031,4 @@ def _consolidate(self, return self.get_job(self.stub.Consolidate(req).job_id) class Consolidater(Client): - """ Deprecated: use Client instead """ \ No newline at end of file + """ Deprecated: use Client instead """