Skip to content

Adopt RFC 8785 JCS for the DSSE-signed inline-leaf predicate (interop determinism) #280

Description

@colek42

Standards-conformance follow-up from testifysec/judge#5559.

The signed predicate (incl. inline leaves) is serialized with Go encoding/json (struct field order + (digest,path) array sort), NOT RFC 8785 JCS. Byte-stable for a single Go producer+verifier, but a non-Go verifier, transparency-log ingestion, a future map-valued field, default HTML-escaping of <,>,&, or 2^53-boundary number formatting would re-canonicalize differently and break signature re-verification.

A conforming JCS canonicalizer already exists in-tree at plugins/attestors/structured-data/internal/canonical/canonical.go.

Decision: adopt JCS for the predicate body before signing (set SetEscapeHTML(false)), OR formally pin the current Go-encoder determinism as the written spec (struct field order normative, leaves sorted (digest,path), HTML-escaping off) + a golden-bytes regression test. Affects all attestors' signing path — do as its own PR, not folded into #5559.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions