Skip to content

SPA still uses the hand-rolled JvCombo dropdown in LLM pool editor and onboarding #1086

Description

@kavin-114

Standing rule (2026-09-02): SPA controls use frappe-ui components and match the sibling control. The Agents Access editor was moved to the frappe-ui Autocomplete in #1084 after its custom dropdown rendered a transparent popup over other content.

Actual: frontend/src/pages/settings/LlmPoolEditor.vue (7 usages, with scoped CSS fighting the focus outline) and OnboardingView.vue still use the custom JvCombo (spec stubs in OnboardingView.spec.js).
Expected: replace them with frappe-ui Autocomplete/Select configured like neighbouring controls, then delete JvCombo.
Suspected location: frontend/src/components/JvCombo.vue and the two views above.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions