Skip to content

auto-refresh config's boutiques descriptor #1174#1365

Open
MontrealSergiy wants to merge 8 commits into
aces:masterfrom
MontrealSergiy:boutiques_refresh#1174
Open

auto-refresh config's boutiques descriptor #1174#1365
MontrealSergiy wants to merge 8 commits into
aces:masterfrom
MontrealSergiy:boutiques_refresh#1174

Conversation

@MontrealSergiy

@MontrealSergiy MontrealSergiy commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

Auto-refresh tool config boutiques descriptor by checking the json file timestap.

Not sure how well scales. Perhaps create race conditions (task started with old boutiques, then post-processed to a recent one), well, that may happen with current codebase too

resolves #1174

@MontrealSergiy MontrealSergiy added Enhancement Boutiques Boutiques integration Admin Features or bugs related to administrative features labels Dec 8, 2023
@MontrealSergiy MontrealSergiy self-assigned this Dec 8, 2023

@prioux prioux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

Comment thread BrainPortal/app/models/tool_config.rb Outdated
Comment thread BrainPortal/lib/boutiques_support.rb Outdated
Comment thread BrainPortal/lib/boutiques_support.rb Outdated
@prioux

prioux commented Mar 20, 2025

Copy link
Copy Markdown
Member

Please review my comments.

@MontrealSergiy

MontrealSergiy commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

I agree with changes, but not sure will pr work, or at least not causing issues with old style boutiques, I think I'd add some safeguard

@prioux

prioux commented Apr 1, 2025

Copy link
Copy Markdown
Member

Please address my comments that were made three weeks ago!

@MontrealSergiy MontrealSergiy force-pushed the boutiques_refresh#1174 branch from 3f9dc01 to bdeebf0 Compare April 2, 2025 16:28
@MontrealSergiy MontrealSergiy requested a review from prioux April 2, 2025 18:35

@prioux prioux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor. I want to remove a feature.

Comment thread BrainPortal/lib/boutiques_support.rb Outdated
Comment thread BrainPortal/app/models/tool_config.rb Outdated
@MontrealSergiy MontrealSergiy force-pushed the boutiques_refresh#1174 branch from 44e7728 to d9c125d Compare May 8, 2025 20:40
@MontrealSergiy MontrealSergiy requested a review from prioux May 13, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Features or bugs related to administrative features Boutiques Boutiques integration Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to force a reload of a descriptor in the new integrator

2 participants