skip summarizing downvoted comments

[abuzarmahmood]

[abuzarmahmood]

The issue involves modifying a GitHub bot to skip summarizing comments that have been downvoted. The changes suggested by the agents focus on updating the logic for processing and summarizing comments in the bot's code.

Files Identified for Modification:

1. triggers.py: Contains functions to check conditions related to GitHub issues, possibly identifying which comments to summarize.
2. agents.py: Involved in agent creation and configuration, possibly including logic for processing comments.
3. response_agent.py: Responsible for generating responses to GitHub issues, including summarizing comments.
4. git_utils.py: Contains utility functions for interacting with the GitHub API, including fetching comments.

Specific Changes Suggested:

1. Modify Comment Processing Logic

   • File: git_utils.py
   • Lines: 87-110
   • Change: Update the get_issue_comments function to filter out downvoted comments.
   • Code Snippet:

     def get_issue_comments(issue: Issue) -> List[IssueComment]:
         """Get all comments for a specific issue or pull request, ignoring Graphite-related comments"""
         ignore_text = "app.graphite.dev"
     
         if isinstance(issue, PullRequest):
             comments = issue.get_issue_comments()
         else:
             comments = issue.get_comments()
     
         # Filter out comments containing the ignore_text or downvoted comments
         filtered_comments = [
             comment for comment in comments
             if ignore_text not in comment.body and comment.reactions['-1'] == 0
         ]
     
         return list(filtered_comments)

2. Update Comment Summarization Logic

   • File: response_agent.py
   • Lines: 274-343
   • Change: Ensure that the summarization logic only processes comments that are not downvoted.
   • Code Snippet:

     def summarize_relevant_comments(
             issue: Issue,
             repo_name: str,
     ) -> Tuple[str, list]:
         """Summarize relevant comments for a given issue"""
     
         repo_path = bot_tools.get_local_repo_path(repo_name)
         details = get_issue_details(issue)
     
         last_comment, comment_str, comment_list = parse_comments(
             repo_name, repo_path, details, issue)
     
         # Filter out downvoted comments
         comment_list = [comment for comment in comment_list if comment.reactions['-1'] == 0]
     
         prompt_kwargs = {
             "repo_name": repo_name,
             "repo_path": repo_path,
             "details": details,
             "issue": issue,
         }
     
         comment_summary_assistant = create_agent(
             "comment_summary_assistant", llm_config)
         summarized_comments = []
         for comment in comment_list[:-1]:
             summary_prompt = generate_prompt(
                 "comment_summary_assistant",
                 **prompt_kwargs,
                 feedback_text=comment_list[-1],
                 results_to_summarize=[comment],
             )
     
             chat_config = dict(
                 recipient=comment_summary_assistant,
                 message=summary_prompt,
                 max_turns=1,
                 silent=params['print_llm_output']
             )
             comment_summary_results = comment_summary_assistant.initiate_chat(
                 **chat_config)
     
             response = comment_summary_results.chat_history[-1]['content']
             summarized_comments.append(response)
     
         # Remove all mentioned of "IS_RELEVANT", "NOT_RELEVANT", and "" from the summaries
         summarized_comments = [re.sub(r'\bIS_RELEVANT\b', '', comment)
                                for comment in summarized_comments]
         summarized_comments = [re.sub(r'\bNOT_RELEVANT\b', '', comment)
                                for comment in summarized_comments]
         summarized_comments = [re.sub(r'\bTERMINATE\b', '', comment)
                                for comment in summarized_comments]
         # Make sure to remove any empty strings and new lines
         summarized_comments = [comment.strip() for comment in summarized_comments]
         # Keep only comments with content
         summarized_comments = [comment for comment in summarized_comments if check_not_empty(
             comment)]
     
         summary_comment_str = '\n====================================================\n'.join(
             summarized_comments)
     
         return summarized_comments, comment_list, summary_comment_str

These changes aim to ensure that the bot skips summarizing comments that have been downvoted, effectively addressing the issue raised.

---

This response was automatically generated by blech_bot using model gpt-4o

[abuzarmahmood]

Summary of Suggestions and Changes

1. Files Identified for Modification:

   • triggers.py: Contains functions to check conditions related to GitHub issues, potentially responsible for determining which comments are summarized.
   • agents.py: Responsible for agent creation and configuration, might include logic for processing comments.
   • response_agent.py: Used for generating responses to GitHub issues, might contain logic for summarizing comments.
   • git_utils.py: Contains utility functions for interacting with the GitHub API, might include functions to retrieve comments and their metadata.

2. Plan to Address the Issue:

   • Identify where comments are retrieved and processed.
   • Implement logic to filter out downvoted comments.
   • Ensure the summarization process only includes comments that are not downvoted.

3. Specific Changes Suggested:

   • Filter Downvoted Comments:

     • File: git_utils.py
     • Line: 87-110
     • Description: Modify the get_issue_comments function to filter out comments that have been downvoted by checking the reactions on each comment.
     • Code Snippet:

       def get_issue_comments(issue: Issue) -> List[IssueComment]:
           """Get all comments for a specific issue or pull request, ignoring Graphite-related comments"""
           ignore_text = "app.graphite.dev"
       
           if isinstance(issue, PullRequest):
               comments = issue.get_issue_comments()
           else:
               comments = issue.get_comments()
       
           # Filter out comments containing the ignore_text and downvoted comments
           filtered_comments = [
               comment for comment in comments
               if ignore_text not in comment.body and comment.reactions['-1'] <= comment.reactions['+1']
           ]
       
           return list(filtered_comments)

   • Update Summarization Logic:

     • File: response_agent.py
     • Line: 274-343
     • Description: Ensure that the summarize_relevant_comments function only processes comments that are not downvoted. No additional changes needed as filtering is handled in get_issue_comments.

   • Ensure Consistent Comment Retrieval:

     • File: triggers.py
     • Line: 33-48
     • Description: Ensure all functions retrieving comments use the updated get_issue_comments function. No changes needed as the function is already used consistently.

By implementing these changes, the bot will effectively skip summarizing downvoted comments, addressing the user's request.

---

This response was automatically generated by blech_bot using model gpt-4o

[abuzarmahmood]

Summary of Suggestions and Changes

1. Files Identified for Modification:

   • triggers.py: Contains functions to check conditions related to GitHub issues, potentially relevant for identifying downvoted comments.
   • agents.py: Responsible for agent creation and configuration, possibly involved in summarizing comments.
   • response_agent.py: Likely involved in generating responses, relevant for implementing logic to skip downvoted comments.
   • git_utils.py: Contains utility functions for interacting with the GitHub API, including fetching issue comments, necessary for identifying downvoted comments.

2. Plan to Address the Issue:

   • Identify where comments are fetched and processed.
   • Implement logic to detect downvoted comments.
   • Modify the summarization process to skip these comments.

3. Specific Changes Suggested:

   • Detect Downvoted Comments:

     • File: git_utils.py
     • Description: Modify the get_issue_comments function to include logic for detecting downvoted comments by checking for specific reactions or labels.
     • Code Snippet:

       def get_issue_comments(issue: Issue) -> List[IssueComment]:
           # Existing code...
           filtered_comments = [
               comment for comment in comments
               if ignore_text not in comment.body and not is_downvoted(comment)
           ]
           return list(filtered_comments)
       
       def is_downvoted(comment: IssueComment) -> bool:
           # Logic to determine if a comment is downvoted
           # This could involve checking for specific reactions or labels
           return 'downvote' in [reaction.content for reaction in comment.get_reactions()]

   • Skip Summarizing Downvoted Comments:

     • File: response_agent.py
     • Description: Modify the summarize_relevant_comments function to ensure it skips downvoted comments.
     • Code Snippet:

       def summarize_relevant_comments(issue: Issue, repo_name: str) -> Tuple[str, list]:
           # Existing code...
           for comment in comment_list[:-1]:
               if not is_downvoted(comment):
                   summary_prompt = generate_prompt(
                       "comment_summary_assistant",
                       **prompt_kwargs,
                       feedback_text=comment_list[-1],
                       results_to_summarize=[comment],
                   )
                   # Existing code...

These changes aim to ensure that the bot skips summarizing comments that have been downvoted, aligning with the user's request.

---

This response was automatically generated by blech_bot using model gpt-4o