Skip to content

Incompatible with protobuf 34.0 #53

Description

@dbermond

It fails to build with protobuf 34.1 with the following error:

/build/hefur/src/hefur/mimosa/mimosa/rpc/gen/protoc-gen-mimosa.cc:9:10: fatal error: google/protobuf/compiler/cpp/generator.h: No such file or directory
    9 | #include <google/protobuf/compiler/cpp/generator.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [mimosa/mimosa/rpc/gen/CMakeFiles/protoc-gen-mimosa.dir/build.make:79: mimosa/mimosa/rpc/gen/CMakeFiles/protoc-gen-mimosa.dir/protoc-gen-mimosa.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1772: mimosa/mimosa/rpc/gen/CMakeFiles/protoc-gen-mimosa.dir/all] Error 2

This is exactly the same problem discussed in #52. Upstream protobuf restored the private headers that were previously removed, but postponed the removal to a later version, giving time for developers to adapt.

It looks like the time has come for the definitive removal, as the private headers were permanently removed as a breaking-change in protobuf 34.0: protocolbuffers/protobuf@3a2af35

It is possible to make hefur to build with a workaround, by the using the protobuf sources and adding the private headers location to the include path in CXXFLAGS (as shown here), but this is far from optimal at the packing level, needing a change to keep going with protubuf 34.0 and later.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions