Commit 202d674
docs: state honestly that the L4 pool cannot register a hit
README advertised sluice_pool_hits_total 4821 for a pool that is structurally
incapable of a hit on the L4 path: each copy direction half-closes its
destination, and TestPooledConnHalfClosedIsNotPooled asserts a half-closed
connection is never pooled, so every L4 request dials a fresh socket.
Making the counter move requires not forwarding the client FIN. That was
implemented and reverted (kept on attempted/tcp-pool-reuse) because it broke
two things that matter more than reuse: a client that half-closes and waits
received an empty response, and the abandoned socket went back into the pool
still owing a reply, so the next client could be served the previous client's
response body. Both reproduced.
config.example.yaml shipped enabled: true while the README called pooling
opt-in. It now ships disabled, with the reason inline.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 75933b7 commit 202d674
2 files changed
Lines changed: 24 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
299 | | - | |
| 299 | + | |
| 300 | + | |
300 | 301 | | |
301 | 302 | | |
302 | 303 | | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
303 | 321 | | |
304 | 322 | | |
305 | 323 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
82 | 86 | | |
83 | | - | |
| 87 | + | |
84 | 88 | | |
85 | 89 | | |
86 | 90 | | |
| |||
0 commit comments